Skip to content

id_prefix inconsistencies (for external/import needs) #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrisjsewell opened this issue Apr 17, 2025 · 0 comments
Open

id_prefix inconsistencies (for external/import needs) #1442

chrisjsewell opened this issue Apr 17, 2025 · 0 comments
Assignees
@chrisjsewell
Labels
bug

Comments

@chrisjsewell
Copy link
Member

Firstly, for external need sources the id_prefix is upper-cased, whereas for import needs it is not.

Then, there are inconsistencies in

sphinx-needs/sphinx_needs/utils.py

Line 212 in 9ee2628

def import_prefix_link_edit(

  • It may look for all "internal" need IDs, if the needmport includes a filter
  • It will not prefix <ID>.<PART_ID> links, only <ID> links
  • The "blanket" find/replace of <ID> for <PREFIX><ID> in the content is pretty horrible
@chrisjsewell chrisjsewell self-assigned this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjsewell chrisjsewell

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisjsewell