-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tricky translation string for post author, time and source #56
Comments
I believe I've solved for this in recent revisions to "postcards." For example, in this Timeline example, avatar, name, time, and source are all separate. Does that address the problem, @rjmackay? |
@brandonrosage each item needs to have
or maybe just one
@rjmackay can you chime in here? |
We haven't solved this. Because we still have HTML wrapping the author we can't combine author into the same translation string as source + date. Its really made worse by the commas between each portion. We end up with a translation that begins with a comma like: ", {{date}}, via {{source}}" TBH this is super minor - so we could just ignore it for now. |
The pattern library creates some tricky to translate strings https://www.dropbox.com/s/qz7f0ui1v3me75f/Screenshot%202016-05-17%2016.06.11.png?dl=0
"Jess Shorland, 45 mins, via SMS" would ideally be built from a single translation string of "{Name}, {post date}, via {source}"
This allows translators to reorder the phrase as appropriate for their language. However because formatting and link around the user name (and probably the avatar too) we have to either:
Could we change the format here and make theses clearly 3 separate elements? .. or maybe theres another better solution.
We can work around this in the client, but the solutions are awkward.
The text was updated successfully, but these errors were encountered: