Update rules/msk_topic_config_comments.md

sbuliarca · matthewhughes-uw · web-flow · commit 30b031b3cd13 · 2024-11-05T18:57:01.000+02:00
Co-authored-by: Matt Hughes &lt;128392218+matthewhughes-uw@users.noreply.github.com&gt;
diff --git a/rules/msk_topic_config_comments.md b/rules/msk_topic_config_comments.md
@@ -30,8 +30,8 @@ resource "kafka_topic" "good_topic" {
     # keep data in primary storage for 1 day
     "local.retention.ms"    = "86400000"
     "retention.ms"          = "2592000000" # keep data for 1 month
-    "max.message.bytes"     = "3145728"    # allow for a batch of records maximum 3MB
-    "retention.bytes"       = "1610612736" # keep on each partition 1.5GB
+    "max.message.bytes"     = "3145728"    # allow for a batch of records maximum 3MiB
+    "retention.bytes"       = "1610612736" # keep on each partition 1.5GiB
     "compression.type"      = "zstd"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ resource "kafka_topic" "good_topic" {`
`30`	`30`	`# keep data in primary storage for 1 day`
`31`	`31`	`"local.retention.ms" = "86400000"`
`32`	`32`	`"retention.ms" = "2592000000" # keep data for 1 month`
`33`		`- "max.message.bytes" = "3145728" # allow for a batch of records maximum 3MB`
`34`		`- "retention.bytes" = "1610612736" # keep on each partition 1.5GB`
	`33`	`+ "max.message.bytes" = "3145728" # allow for a batch of records maximum 3MiB`
	`34`	`+ "retention.bytes" = "1610612736" # keep on each partition 1.5GiB`
`35`	`35`	`"compression.type" = "zstd"`
`36`	`36`	`}`
`37`	`37`	`}`