Fix rubocop offense

Author: maximenoel8

testsuite/features/step_definitions/api_common.rb

@@ -10,16 +10,18 @@
 
 When(/^I delete all the imported terminals$/) do
   terminals = read_terminals_from_yaml
-  short_names_to_process = terminals.reject do |terminal_name|
-    terminal_name.include?('minion') || terminal_name.include?('client')
-  end
+  short_names_to_process =
+    terminals.reject do |terminal_name|
+      terminal_name.include?('minion') || terminal_name.include?('client')
+    end
   log "Terminals identified for deletion (short names): #{short_names_to_process.join(', ')}"
   current_systems = $api_test.system.list_systems
   full_names_to_delete = []
   short_names_to_process.each do |short_name|
-    match = current_systems.find do |s|
-      s['name'].split('.').include?(short_name)
-    end
+    match =
+      current_systems.find do |s|
+        s['name'].split('.').include?(short_name)
+      end
     if match
       full_names_to_delete << match['name']
     else
@@ -29,7 +31,7 @@
   if full_names_to_delete.any?
     $api_test.system.delete_systems_by_name(full_names_to_delete)
   else
-    log "No matching systems found to delete."
+    log 'No matching systems found to delete.'
   end
 end
 

testsuite/features/step_definitions/retail_steps.rb

@@ -17,8 +17,8 @@
   # Server Applications, proxy product and modules, proxy devel
   if os_family.match?(/^sles/) && os_version.match?(/^15/)
     repos += 'proxy_module_pool_repo proxy_module_update_repo ' \
-      'proxy_product_pool_repo proxy_product_update_repo ' \
-      'module_server_applications_pool_repo module_server_applications_update_repo '
+             'proxy_product_pool_repo proxy_product_update_repo ' \
+             'module_server_applications_pool_repo module_server_applications_update_repo '
     repos += 'proxy_devel_releasenotes_repo proxy_devel_repo ' unless $build_validation || product_version_full.include?('-released')
   elsif os_family.match?(/^opensuse/)
     repos += 'proxy_pool_repo ' unless $is_containerized_server
@@ -33,9 +33,9 @@
   when 'Uyuni'
     step 'I enable repositories before installing branch server'
     cmd = 'zypper --non-interactive --ignore-unknown remove atftp && ' \
-      'zypper --non-interactive install tftp && ' \
-      'systemctl enable tftp.service && ' \
-      'systemctl start tftp.service'
+          'zypper --non-interactive install tftp && ' \
+          'systemctl enable tftp.service && ' \
+          'systemctl start tftp.service'
     get_target('proxy').run(cmd)
     step 'I disable repositories after installing branch server'
   else
@@ -117,17 +117,17 @@
     #                  otherwise the name server we get from DHCP is lost at the end of the list
     #                  (the name servers list in resolv.conf is limited to 3 entries)
     cmd = 'nmcli connection modify "Wired connection 1" ipv4.dns-priority 20 && ' \
-      "nmcli device modify #{node.public_interface} ipv4.dns-priority 20 && " \
-      'nmcli connection modify "Wired connection 2" ipv4.dns-priority 10 && ' \
-      "nmcli device modify #{node.private_interface} ipv4.dns-priority 10"
+          "nmcli device modify #{node.public_interface} ipv4.dns-priority 20 && " \
+          'nmcli connection modify "Wired connection 2" ipv4.dns-priority 10 && ' \
+          "nmcli device modify #{node.private_interface} ipv4.dns-priority 10"
   else
     # Wicked: is there a way to give eth1 precedence?
     #         we use a static setting for the name server instead
     static_dns = net_prefix + PRIVATE_ADDRESSES['dhcp_dns']
     cmd = 'echo -e "BOOTPROTO=dhcp\nSTARTMODE=auto\n" > /etc/sysconfig/network/ifcfg-eth1 && ' \
-      'ifup eth1 && ' \
-      "sed -i 's/^NETCONFIG_DNS_STATIC_SERVERS=\".*\"/NETCONFIG_DNS_STATIC_SERVERS=\"#{static_dns}\"/' /etc/sysconfig/network/config && " \
-      'netconfig update -f'
+          'ifup eth1 && ' \
+          "sed -i 's/^NETCONFIG_DNS_STATIC_SERVERS=\".*\"/NETCONFIG_DNS_STATIC_SERVERS=\"#{static_dns}\"/' /etc/sysconfig/network/config && " \
+          'netconfig update -f'
   end
   node.run(cmd)
 end

testsuite/features/support/api_test.rb

@@ -38,12 +38,13 @@ def initialize(_host)
     @token = nil
     @semaphore = Mutex.new
 
-    file = File.open('api.log', 'a')
-    file.sync = true
-    @logger = Logger.new(file)
-    @logger.level = Logger::INFO
-    @logger.formatter = proc do |severity, datetime, progname, msg|
-      "#{datetime.strftime('%H:%M:%S')} [#{severity}] #{msg}\n"
+    File.open('api.log', 'a') do |file|
+      file.sync = true
+      @logger = Logger.new(file)
+      @logger.level = Logger::INFO
+      @logger.formatter = proc do |severity, datetime, progname, msg|
+        "#{datetime.strftime('%H:%M:%S')} [#{severity}] #{msg}\n"
+      end
     end
   end
 

testsuite/features/support/retail.rb

@@ -97,13 +97,13 @@ def execute_expect_command_proxy(host, exp_file, interface)
     mac = $sle15sp7_terminal_mac
   end
   mac = mac.tr(':', '')
-  hex = (("#{mac[0..5]}fffe#{mac[6..11]}").to_i(16) ^ 0x0200000000000000).to_s(16)
+  eui64_base = "#{mac[0..5]}fffe#{mac[6..11]}"
+  hex = (eui64_base.to_i(16) ^ 0x0200000000000000).to_s(16)
   ipv6 = "fe80::#{hex[0..3]}:#{hex[4..7]}:#{hex[8..11]}:#{hex[12..15]}%#{interface}"
-
   source = "#{File.dirname(__FILE__)}/../upload_files/#{exp_file}"
   dest = "/tmp/#{exp_file}"
   success = file_inject(get_target('proxy'), source, dest)
   raise ScriptError, 'File injection failed' unless success
 
   get_target('proxy').run("expect -f /tmp/#{exp_file} #{ipv6}")
-end
+end