General release Aug 20 2025 (#24)

Changes:
 - Updated LCEVCdecJS to expect newly formatted dual-track streams.

Fixes:
 - Resolved a possible use-after-free bug in LCEVCdecJS.
 - Fixed unreliable isLive checks for dual-track contents.
 - Ensure onExitPictureInPicture listeners are properly removed when LCEVCdecJS instance is destroyed.

Author: v-nova-romas

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "lcevc_dec.js",
-	"version": "1.2.1",
+	"version": "1.3.0",
 	"description": "V-Nova MPEG-5 LCEVC Decoder",
 	"main": "dist/lcevc_dec.min.js",
 	"scripts": {
@@ -51,6 +51,7 @@
 		"@rollup/plugin-replace": "^4.0.0",
 		"@rollup/plugin-typescript": "^8.5.0",
 		"@types/estree": "^1.0.0",
+		"@types/node": "^22.17.1",
 		"@typescript-eslint/eslint-plugin": "^5.0.0",
 		"@typescript-eslint/parser": "^5.0.0",
 		"babel-loader": "^8.2.2",

src/controllers/video_controller.js

@@ -175,6 +175,9 @@ class VideoControls {
 
   /** @private @type {boolean} */
   #isLive = null;
+
+  /** @private @type {boolean} */
+  #hasCheckedLive = false;
   // #endregion
 
   // #region Events
@@ -834,15 +837,23 @@ class VideoControls {
    *
    * If the given time is greater than 1, then the video is a live one.
    * This can be a false positive if a live stream current time is less than 1
-   * when this is call.
+   * when this is called.
+   *
+   * This method can only be called once. Subsequent calls have no effect.
    *
    * @param {!number} currentTime The current time of the video.
    * @returns {Result} The status code.
    * @memberof VideoControls
    * @public
    */
   _checkIsLive(currentTime) {
+    if (this.#hasCheckedLive) {
+      return Result.OK;
+    }
+
     this.#isLive = currentTime > 1;
+    this.#hasCheckedLive = true;
+
     return Result.OK;
   }
 

src/demux/demuxer.js

@@ -386,6 +386,7 @@ class Demuxer {
           // Raw LCEVC data can be directly passed to the residual store, whereas encapsulated
           // LCEVC data will need further demuxing and processing
           if (this.#isRawLcevc) {
+            Demuxer.convertLengthPrefixToAnnexB(data);
             this._demuxedLcevcData(data, ...frameSample.slice(0, -1), level);
           } else {
             Demuxer.convertLengthPrefixToAnnexB(data);

src/dpi.js

@@ -789,7 +789,7 @@ class DPI {
    * @public
    */
   _reset(residualStore, timestamp, profileSwitch) {
-    Log.msg('reset');
+    Log.msg('Reset');
     this.#decoderResetProgress = true;
     libDPI._perseus_decoder_close(this.#lcevcDecoderPointer);
     this.#lcevcDecoderPointer = libDPI._perseus_decoder_open_wrapper(1);
@@ -807,9 +807,11 @@ class DPI {
       }
 
       if (!parsedLcevc) {
-        Log.warn(`Failed to load and parse lcevc data for timestamp: ${timestamp}`);
+        Log.warn(`Failed to load and parse LCEVC data for timestamp: ${timestamp}`);
         if (libDPI && this.#pssData.pointer) {
+          Log.debug('Freeing and re-allocating LCEVC data.');
           this.#freePssData();
+          this.#initPssData();
         }
         this.#decoderResetProgress = false;
         return Result.FAIL;
@@ -826,6 +828,18 @@ class DPI {
     return Result.OK;
   }
 
+  /**
+   * Init the buffer for LCEVC data with an initial size of 1.
+   *
+   * @returns {Result} The status code.
+   * @memberof DPI
+   * @private
+   */
+  #initPssData() {
+    this.#pssData = { pointer: _createDataPointer(libDPI, new Uint8Array(1)), size: 1 };
+    return Result.OK;
+  }
+
   /**
    * Clear the allocated data of the LCEVC from the libDPI.
    *

src/lcevc_dec.js

@@ -1877,7 +1877,9 @@ class LCEVCdec {
     // Clear previous render times because this will cause incorrect
     // audio delay to be calculated, since in PiP mode the
     // render times are inaccurate
-    this.#queue._clearPreviousRenderTimes();
+    if (this.#queue) {
+      this.#queue._clearPreviousRenderTimes();
+    }
 
     this.#pictureInPicture = {
       active: false,
@@ -2461,6 +2463,11 @@ class LCEVCdec {
       this.#lcevcWorker = null;
     }
 
+    // Cleanup PictureInPicture listeners.
+    if (window.documentPictureInPicture) {
+      this.#removeAllListeners(window.documentPictureInPicture, 'enter');
+    }
+
     // Video listeners.
     this.#unbindVideoEvents();
     this.#eventHandler = null;
@@ -2518,7 +2525,7 @@ class LCEVCdec {
       });
     }
 
-    console.info('::::: closing LCEVCdec :::::'); // eslint-disable-line
+    Log.always('Closing the LCEVC decoder.');
     return Result.OK;
   }