Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin Maven Plugin not thread-safe #6688

Open
knoobie opened this issue Aug 23, 2024 · 4 comments
Open

Vaadin Maven Plugin not thread-safe #6688

knoobie opened this issue Aug 23, 2024 · 4 comments
Labels

Comments

@knoobie
Copy link
Contributor

knoobie commented Aug 23, 2024

Describe the bug

    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * Your build is requesting parallel execution, but this         *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * project contains the following plugin(s) that have goals not  *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * marked as thread-safe to support parallel execution.          *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * While this /may/ work fine, please look for plugin updates    *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * and/or request plugins be made thread-safe.                   *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * If reporting an issue, report it against the plugin in        *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - * question, not against Apache Maven.                           *
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - The following plugins are not marked as thread-safe in Project Name:
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -   com.vaadin:vaadin-maven-plugin:24.4.10
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon -
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - Enable debug to see precisely which goals are not marked as thread-safe.
    [mvn-builder-project] WARNING org.apache.maven.lifecycle.internal.builder.BuilderCommon - *****************************************************************

Expected-behavior

No such error.

Reproduction

Build any Vaadin Multi Module Project with Maven and enable parallel execution to speed up build.

System Info

Latest 24.4

@knoobie knoobie added the bug label Aug 23, 2024
@manolo
Copy link
Member

manolo commented Aug 23, 2024

I have seen this message before when building platform o flow-components that are using parallel execution, but we have not experienced any problem, so we just ignore the message, has you had any issue in your projects?

@knoobie
Copy link
Contributor Author

knoobie commented Aug 23, 2024

Not seen a problem in the final product; but maven is literally crying ;) and all WARNING logs are preserved in Jenkins.. so it's not a good DX / advertising for the plugin

@manolo
Copy link
Member

manolo commented Aug 23, 2024

which goal do you expect to be thread-safe ? prepare-frontend or build-frontend ?

@knoobie
Copy link
Contributor Author

knoobie commented Aug 23, 2024

I would expect build-frontend used in the production build to be thread-safe.. I would say even running a multi module project with different Vaadin modules should not be a problem because each has its own node modules, package json etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants