chore: collect server statistics only on server side #19913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server side statistics are not sent to the browser anymore but directly registered when dev-tools websocket connection is opened and closed. Fixes vaadin/platform#6724
tltv
requested changes
Sep 10, 2024
vaadin-dev-server/src/main/java/com/vaadin/base/devserver/stats/DevModeUsageStatistics.java
Outdated
Show resolved
Hide resolved
vaadin-dev-server/src/main/java/com/vaadin/base/devserver/stats/StatisticsStorage.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomi Virtanen <[email protected]>
|
tltv
approved these changes
Sep 10, 2024
|
Merge is pending on confirmation that it's OK to leave server stats out from the request sent from the browser to the stats server. |
|
I converted the PR to draft to prevent being merged accidentally |
|
Statistics V1 endpoint is still in use for server originated stats and we don't want to deprecate this at the moment, thus let's close the pull request and keep the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Server side statistics are not sent to the browser anymore but directly registered when dev-tools websocket connection is opened and closed.
Fixes vaadin/platform#6724
Type of change
Checklist
Additional for
Featuretype of change