Skip to content

Commit 8b9d871

Browse files
authored
chore: update sauce connect launcher (#630)
1 parent 5e6b026 commit 8b9d871

7 files changed

+305
-4667
lines changed

.github/workflows/unit-tests.yml

+37-43
Original file line numberDiff line numberDiff line change
@@ -4,58 +4,52 @@ name: Unit Tests
44
on: pull_request
55

66
jobs:
7-
unit-tests-p2:
8-
name: Polymer 2 on the CI agent
9-
runs-on: ubuntu-latest
10-
steps:
11-
- name: Set up Node 12.x
12-
uses: actions/setup-node@v4
13-
with:
14-
node-version: 12.x
15-
16-
- name: Check out the source code
17-
uses: actions/checkout@v4
18-
19-
- name: Install latest npm
20-
# magi-cli 1.0 requires npm 7 or higher
21-
run: "npm install -g npm@8"
22-
23-
- name: Install global npm dependencies
24-
# bower is needed to run 'bower install'
25-
# polymer-cli is needed to run the lint step
26-
run: "npm install --quiet --no-progress --global bower polymer-cli"
27-
28-
- name: Install project npm dependencies
29-
run: "npm ci"
30-
31-
- name: Install project Bower dependencies
32-
run: "bower install --quiet"
33-
34-
- name: Run automated magi-cli checks
35-
run: "npm run check"
36-
37-
- name: Run a linter
38-
run: "npm run lint"
39-
40-
# the full set of environments is tested with Polymer 3 below
41-
- name: Run unit tests locally (in the VM instance running this job)
42-
run: "xvfb-run -s '-screen 0 1024x768x24' npm test"
7+
# Running local tests is disabled due to outdated dependencies
8+
# see https://github.com/vaadin/components-team-tasks/issues/628
9+
# unit-tests-p2:
10+
# name: Polymer 2 on the CI agent
11+
# runs-on: ubuntu-latest
12+
# steps:
13+
# - name: Set up Node 16.x
14+
# uses: actions/setup-node@v4
15+
# with:
16+
# node-version: 16.x
17+
#
18+
# - name: Check out the source code
19+
# uses: actions/checkout@v2
20+
#
21+
# - name: Install global npm dependencies
22+
# # bower is needed to run 'bower install'
23+
# # polymer-cli is needed to run the lint step
24+
# run: "npm install --quiet --no-progress --global bower polymer-cli"
25+
#
26+
# - name: Install project npm dependencies
27+
# run: "npm ci"
28+
#
29+
# - name: Install project Bower dependencies
30+
# run: "bower install --quiet"
31+
#
32+
# - name: Run automated magi-cli checks
33+
# run: "npm run check"
34+
#
35+
# - name: Run a linter
36+
# run: "npm run lint"
37+
#
38+
# # the full set of environments is tested with Polymer 3 below
39+
# - name: Run unit tests locally (in the VM instance running this job)
40+
# run: "xvfb-run -s '-screen 0 1024x768x24' npm test"
4341

4442
unit-tests-p3:
4543
name: Polymer 3 on SauceLabs
4644
runs-on: ubuntu-latest
4745
steps:
48-
- name: Set up Node 12.x
46+
- name: Set up Node 16.x
4947
uses: actions/setup-node@v4
5048
with:
51-
node-version: 12.x
49+
node-version: 16.x
5250

5351
- name: Check out the (Polymer 2) source code
54-
uses: actions/checkout@v4
55-
56-
- name: Install latest npm
57-
# magi-cli 1.0 requires npm 7 or higher
58-
run: "npm install -g npm@8"
52+
uses: actions/checkout@v2
5953

6054
- name: Install global npm dependencies
6155
# bower and polymer-modulizer are needed to run the Polymer 3 conversion step
File renamed without changes.

README.md

+3
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ If the license is valid, it will be saved to the local storage of the browser an
111111

112112
## Running tests from the command line
113113

114+
> [!WARNING]
115+
> Running tests locally from the CLI does not work due to outdated dependencies. Run tests via SauceLabs or in the browser instead.
116+
114117
1. When in the `vaadin-charts` directory, run `polymer test`
115118

116119

package-lock-p3.json

+32-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"name": "@vaadin/vaadin-charts",
3-
"version": "6.3.7",
3+
"version": "6.3.8",
44
"lockfileVersion": 3,
55
"requires": true,
66
"packages": {
77
"": {
88
"name": "@vaadin/vaadin-charts",
9-
"version": "6.3.7",
9+
"version": "6.3.8",
1010
"license": "SEE LICENSE IN LICENSE.txt",
1111
"dependencies": {
1212
"@polymer/polymer": "^3.0.0",
@@ -9743,17 +9743,17 @@
97439743
},
97449744
"node_modules/sauce-connect-launcher": {
97459745
"version": "1.3.2",
9746-
"resolved": "https://registry.npmjs.org/sauce-connect-launcher/-/sauce-connect-launcher-1.3.2.tgz",
9747-
"integrity": "sha512-wf0coUlidJ7rmeClgVVBh6Kw55/yalZCY/Un5RgjSnTXRAeGqagnTsTYpZaqC4dCtrY4myuYpOAZXCdbO7lHfQ==",
9746+
"resolved": "git+ssh://[email protected]/vaadin/sauce-connect-launcher.git#20fca782221404fef626c985e975268bfaba05cd",
97489747
"dev": true,
97499748
"hasInstallScript": true,
9749+
"license": "MIT",
97509750
"optional": true,
97519751
"dependencies": {
9752-
"adm-zip": "~0.4.3",
9753-
"async": "^2.1.2",
9752+
"adm-zip": "^0.4.14",
9753+
"async": "^3.2.0",
97549754
"https-proxy-agent": "^5.0.0",
9755-
"lodash": "^4.16.6",
9756-
"rimraf": "^2.5.4"
9755+
"lodash": "^4.17.15",
9756+
"rimraf": "^3.0.2"
97579757
},
97589758
"engines": {
97599759
"node": ">= 4"
@@ -9772,6 +9772,13 @@
97729772
"node": ">= 6.0.0"
97739773
}
97749774
},
9775+
"node_modules/sauce-connect-launcher/node_modules/async": {
9776+
"version": "3.2.6",
9777+
"resolved": "https://registry.npmjs.org/async/-/async-3.2.6.tgz",
9778+
"integrity": "sha512-htCUDlxyyCLMgaM3xXg0C0LW2xqfuQ6p05pCEIsXuyQ+a1koYKTuBMzRNwmybfLgvJDMd0r1LTn4+E0Ti6C2AA==",
9779+
"dev": true,
9780+
"optional": true
9781+
},
97759782
"node_modules/sauce-connect-launcher/node_modules/https-proxy-agent": {
97769783
"version": "5.0.0",
97779784
"resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-5.0.0.tgz",
@@ -9786,6 +9793,23 @@
97869793
"node": ">= 6"
97879794
}
97889795
},
9796+
"node_modules/sauce-connect-launcher/node_modules/rimraf": {
9797+
"version": "3.0.2",
9798+
"resolved": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
9799+
"integrity": "sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==",
9800+
"deprecated": "Rimraf versions prior to v4 are no longer supported",
9801+
"dev": true,
9802+
"optional": true,
9803+
"dependencies": {
9804+
"glob": "^7.1.3"
9805+
},
9806+
"bin": {
9807+
"rimraf": "bin.js"
9808+
},
9809+
"funding": {
9810+
"url": "https://github.com/sponsors/isaacs"
9811+
}
9812+
},
97899813
"node_modules/select-hose": {
97909814
"version": "2.0.0",
97919815
"resolved": "https://registry.npmjs.org/select-hose/-/select-hose-2.0.0.tgz",

0 commit comments

Comments
 (0)