Skip to content

Commit 10ac406

Browse files
committed
refactor: rename dense to dense layout
1 parent c801860 commit 10ac406

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

packages/dashboard/src/vaadin-dashboard-layout-mixin.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ export declare class DashboardLayoutMixinClass {
2222
/**
2323
* Whether the dashboard layout is dense.
2424
*/
25-
dense: boolean;
25+
denseLayout: boolean;
2626
}

packages/dashboard/src/vaadin-dashboard-layout-mixin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const DashboardLayoutMixin = (superClass) =>
3030
display: none !important;
3131
}
3232
33-
:host([dense]) #grid {
33+
:host([dense-layout]) #grid {
3434
grid-auto-flow: dense;
3535
}
3636
@@ -101,7 +101,7 @@ export const DashboardLayoutMixin = (superClass) =>
101101
* Whether the dashboard layout is dense.
102102
* @type {boolean}
103103
*/
104-
dense: {
104+
denseLayout: {
105105
type: Boolean,
106106
value: false,
107107
reflectToAttribute: true,

packages/dashboard/test/dashboard-layout.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,12 +554,12 @@ describe('dashboard layout', () => {
554554
});
555555
});
556556

557-
describe('dense', () => {
557+
describe('dense layout', () => {
558558
beforeEach(async () => {
559559
dashboard.appendChild(fixtureSync('<div id="2">Item 2</div>'));
560560
childElements = [...dashboard.querySelectorAll('div')];
561561
setColspan(childElements[1], 2);
562-
dashboard.dense = true;
562+
dashboard.denseLayout = true;
563563
await nextFrame();
564564
});
565565

@@ -572,7 +572,7 @@ describe('dashboard layout', () => {
572572
});
573573

574574
it('should retain the order of items', async () => {
575-
dashboard.dense = false;
575+
dashboard.denseLayout = false;
576576
await nextFrame();
577577
/* prettier-ignore */
578578
expectLayout(dashboard, [

packages/dashboard/test/typings/dashboard.types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ assertType<ElementMixinClass>(genericDashboard);
3535
assertType<DashboardLayoutMixinClass>(genericDashboard);
3636
assertType<Array<DashboardItem | DashboardSectionItem<DashboardItem>> | null | undefined>(genericDashboard.items);
3737
assertType<boolean>(genericDashboard.editable);
38-
assertType<boolean>(genericDashboard.dense);
38+
assertType<boolean>(genericDashboard.denseLayout);
3939

4040
assertType<{
4141
selectWidget: string;
@@ -113,7 +113,7 @@ narrowedDashboard.addEventListener('dashboard-item-resize-mode-changed', (event)
113113
/* DashboardLayout */
114114
const layout = document.createElement('vaadin-dashboard-layout');
115115
assertType<DashboardLayout>(layout);
116-
assertType<boolean>(layout.dense);
116+
assertType<boolean>(layout.denseLayout);
117117

118118
assertType<ElementMixinClass>(layout);
119119
assertType<DashboardLayoutMixinClass>(layout);

0 commit comments

Comments
 (0)