Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

512mb limit: No longer true? #97

Open
stockholmux opened this issue May 24, 2024 · 5 comments
Open

512mb limit: No longer true? #97

stockholmux opened this issue May 24, 2024 · 5 comments

Comments

@stockholmux
Copy link
Member

Documentation lists 512mb on key and string sizes many times:

  • /topics/setrange.md
  • /topics/bitmaps.md
  • /topics/keyspace.md
  • /topics/protocol.md

and probably more.

It appears the limitation was removed in 2021 see 4568 on redis. Looks like on issue 1653 on redis-doc there was a never merged issue to update this.

Can anyone confirm that Valkey is no longer subject to the 512mb limit?

@madolson
Copy link
Member

madolson commented May 28, 2024

As discussed, the 512MB limit is no longer a hard limit and can be changed with proto-max-bulk-len. I think we should frame it as, "it's untested to use a higher value than the default, please use at your own risk.

@zuiderkwast
Copy link
Contributor

Why not do PRs directly instead of reporting as issues?

@stockholmux
Copy link
Member Author

@zuiderkwast This is all linked to #91 which is a review process not necessarily an update process. This is so we don't block publishing of the website by waiting to fix dozens of issues.

If something looks super bad, I can suppress publishing until it's fixed, or alternately for not as bad pages, have a warning that says that we're working on it.

Once the review is finished: ready to publish.

@zuiderkwast
Copy link
Contributor

OK, I just thought that in some cases, just posting the changes as a PR seems to be as small and fast as explaining them in an issue. It's sometimes a bit hard to know what exactly you want to be changed from these issues.

@stockholmux
Copy link
Member Author

re: bit hard to know what exactly you want to be changed from these issues

Probably fair! I'll make sure and take another pass on my own issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants