Can we use sdssup for (client*)->argv[x] ?

[WelongZuo]

From processInlineBuffer we can know , each element of client.argv is of type robj* .
But we can also find some uages :
sdsdup(c->argv[2])
sdslen(c->argv[2])
This code writing style is not very rigorous. Can we use it like this in the code?

[WelongZuo]

Can anyone help me ? Thanks

[ranshid]

@WelongZuo might be helpful if you could provide some existing code examples.
I am not sure how sdsdup(c->argv[2]) would work without a bug.

[WelongZuo]

Thanks for reply !

for example search regex sdsdup\(.*c->argv.*\) in the whole code :

1. in debugCommand : code line sdsdup(c->argv[2]->ptr); when process leak option
2. in ldbStartSession : code line sds srcstring = sdsdup(c->argv[1]->ptr);
3. in addACLLogEntry : code line case ACL_DENIED_KEY: le->object = sdsdup(c->argv[argpos]->ptr); break;

[ranshid]

So I am not sure I understand :)

the client argv[i] is a pointer to a server object (so it has different metadata like reference count and type) and it also hold a pointer to Valkey string type which is sds. So doing sdsdup(c->argv[2]) is bad! doing sdsdup(c->argv[2]->ptr) is fine.

in your original comment you wrote:

But we can also find some uages :
sdsdup(c->argv[2])
sdslen(c->argv[2])

which seems to indicate a problem but I was unable to locate such.

[WelongZuo]

Thank you very much, I understand.