Component class used via `import` is incorrectly reported as unused

[jagthedrummer]

When I run yarn ember-unused-components it's reporting playlist/player/abstract as being unused. But I have a file at app/components/playlist/player/compact.js which does this:

import PlaylistPlayerAbstract from './abstract';

[jagthedrummer]

I discovered that the problem goes away if I import the component like this instead:

import PlaylistPlayerAbstract from 'seshy/components/playlist/player/abstract';

[jagthedrummer]

Oddly, I have a different component that I used in a similar way that is still reported as unused even though it's being imported, and I'm using the "full path" style import.

That component is projects/abstract/status which is a class-only component (no template) which is imported and then inherited from by other components that do provide a template.

// app/components/projects/abstract/status.js

import Component from '@glimmer/component';

export default class ProjectsAbstractStatusComponent extends Component {
}

// app/components/projects/icon.js

import ProjectsAbstractStatusComponent from 'seshy/components/projects/abstract/status';

export default class ProjectsIconComponent extends ProjectsAbstractStatusComponent {}

[tniezurawski]

Yeah, some stuff could be improved here but I'll be honest, I don't find much time these days to update the tool... and I feel like it's less relevant in the embroider world 🤔

[jagthedrummer]

@tniezurawski I totally understand about not finding time for this stuff. No worries, I just wanted to report what I noticed. Could you maybe say more about how embroider affects this add-on being relevant? I'm not fully up to speed on that.

[tniezurawski]

Thanks for understanding @jagthedrummer 🙇 AFAIK Embroider won't bundle components that are not being used... or at least that's what I hope for. I should actually check that 😉

The tool still can be useful because removing unused components will contribute to the overall health of the codebase.

[jagthedrummer]

Thanks for the info, @tniezurawski! I agree that this would still be useful. I'm a big fan of reducing the mental load of a code base by removing anything that isn't actively in use. Cheers!