From 431f63943e1ef63eeb79037306b79e33e33577f9 Mon Sep 17 00:00:00 2001
From: mathieuRA <contact@mathieu-raisin.fr>
Date: Mon, 18 Nov 2024 09:56:35 +0100
Subject: [PATCH] changelog

---
 CHANGELOG.unreleased.md                    | 2 ++
 packages/xo-server/src/api/vm.mjs          | 9 ---------
 packages/xo-web/src/xo-app/new-vm/index.js | 5 ++---
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index 6c9f3cd3823..04b94699aa5 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -13,6 +13,7 @@
 
 - Ignore leading and trailing spaces when editing VM/Pools/Hosts/SRs names and descriptions (PR [#8115](https://github.com/vatesfr/xen-orchestra/pull/8115))
 - [VM/Advanced] in Nested virtualization section, add warning tooltip and link to documentation (PR [#8107](https://github.com/vatesfr/xen-orchestra/pull/8107))
+- [REST/VM] When creating a VM, the template's VIFs are created. It is also possible to create more VIFs or delete/update template's VIFs (PR [#8137](https://github.com/vatesfr/xen-orchestra/pull/8137))
 
 ### Bug fixes
 
@@ -40,6 +41,7 @@
 - @xen-orchestra/web patch
 - @xen-orchestra/web-core minor
 - @xen-orchestra/xapi patch
+- xo-server minor
 - xo-web minor
 
 <!--packages-end-->
diff --git a/packages/xo-server/src/api/vm.mjs b/packages/xo-server/src/api/vm.mjs
index 3fce08d4a6b..e8ca4af549f 100644
--- a/packages/xo-server/src/api/vm.mjs
+++ b/packages/xo-server/src/api/vm.mjs
@@ -340,15 +340,6 @@ create.params = {
         },
         device: { type: 'string', optional: true },
         remove: { type: 'boolean', optional: true },
-
-        // device: {
-        //   optional: true,
-        //   type: 'string',
-        // },
-        // remove: {
-        //   optional: true,
-        //   type: 'boolean',
-        // },
       },
     },
   },
diff --git a/packages/xo-web/src/xo-app/new-vm/index.js b/packages/xo-web/src/xo-app/new-vm/index.js
index c827d6a548b..b05cfe61964 100644
--- a/packages/xo-web/src/xo-app/new-vm/index.js
+++ b/packages/xo-web/src/xo-app/new-vm/index.js
@@ -485,9 +485,9 @@ export default class NewVm extends BaseComponent {
     const resourceSet = this._getResourceSet()
     const { template } = this.props
 
-    // In case the user remove some VIFs created by the template
+    // In case user deletes some VIF created by the template
     // We need to mark them with `remove:true`
-    // so that xo-server correctly remove it
+    // so that xo-server deletes them properly
     if (_VIFs.length < templateVifs.length) {
       const _vifByDevice = keyBy(_VIFs, 'device')
       templateVifs.forEach(templateVif => {
@@ -497,7 +497,6 @@ export default class NewVm extends BaseComponent {
       })
     }
 
-    // return
     // Either use `memory` OR `memory*` params
     let { memory, memoryStaticMax, memoryDynamicMin, memoryDynamicMax } = state
     if ((memoryStaticMax != null || memoryDynamicMin != null) && memoryDynamicMax == null) {