From 0ee0428c05ad15e8fe5a54293542bb82dcf8ecfd Mon Sep 17 00:00:00 2001 From: vankichi Date: Fri, 25 Oct 2024 00:49:59 +0900 Subject: [PATCH 1/2] :bug: Fix bind DOCKER_OPTS option Signed-off-by: vankichi --- Makefile.d/docker.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.d/docker.mk b/Makefile.d/docker.mk index 3e0f7563fe..7a09d688e3 100644 --- a/Makefile.d/docker.mk +++ b/Makefile.d/docker.mk @@ -304,7 +304,7 @@ docker/name/loadtest: ## build loadtest image docker/build/loadtest: @make DOCKERFILE="$(ROOTDIR)/dockers/tools/cli/loadtest/Dockerfile" \ - DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \ + DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \ IMAGE=$(LOADTEST_IMAGE) \ docker/build/image @@ -372,7 +372,7 @@ docker/name/benchmark-job: docker/build/benchmark-job: @make DOCKERFILE="$(ROOTDIR)/dockers/tools/benchmark/job/Dockerfile" \ IMAGE=$(BENCHMARK_JOB_IMAGE) \ - DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \ + DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \ docker/build/image .PHONY: docker/name/benchmark-operator @@ -395,5 +395,5 @@ docker/name/example-client: docker/build/example-client: @make DOCKERFILE="$(ROOTDIR)/dockers/example/client/Dockerfile" \ IMAGE=$(EXAMPLE_CLIENT_IMAGE) \ - DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \ + DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \ docker/build/image From 9b2dfdbcded0936d667b4da4537dcab5eacea48f Mon Sep 17 00:00:00 2001 From: Kiichiro YUKAWA Date: Fri, 25 Oct 2024 11:51:06 +0900 Subject: [PATCH 2/2] Fix --- .github/workflows/dockers-example-client-image.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/dockers-example-client-image.yaml b/.github/workflows/dockers-example-client-image.yaml index 32fa1674ee..95e2ac3a71 100644 --- a/.github/workflows/dockers-example-client-image.yaml +++ b/.github/workflows/dockers-example-client-image.yaml @@ -73,5 +73,4 @@ jobs: uses: ./.github/workflows/_docker-image.yaml with: target: example-client - platforms: linux/amd64,linux/arm64 secrets: inherit