Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Gen II encounters for Route 31 #313

Open
antialiasis opened this issue Aug 7, 2020 · 3 comments
Open

Error in Gen II encounters for Route 31 #313

antialiasis opened this issue Aug 7, 2020 · 3 comments

Comments

@antialiasis
Copy link

Somebody bumped into this on TCoD. It looks like the source the Gen II encounter pull request used simply made a mistake here.

If you scroll down that page (Crystal walking encounters) and find Route 31, you'll find it lists Caterpie in the third (20%) slot for morning and day. In reality, this slot has a Bellsprout, as seen in pokecrystal here: https://github.com/pret/pokecrystal/blob/master/data/wild/johto_grass.asm#L1252

For reference, this is the diff for the fix in my fork.
antialiasis@d655ba6

Unfortunately this means the validity of the source's other data is entirely up in the air. I checked a few other random locations and found no other errors, but can't be sure without actually ripping everything to check.

@antialiasis
Copy link
Author

(Incidentally it does seem like pokegold has wild encounters now, so it should be possible to get them from there...)

@magical
Copy link
Member

magical commented Aug 7, 2020

cc @rogerooo

Yep, definitely need to do a re-rip now that pokegold has encounter data (thanks for pointing that out!)

@magical
Copy link
Member

magical commented Aug 19, 2020

Looks like there are a bunch of issues with GSC encounters: #315. I think maybe we should revert them until a proper rip can be done. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants