Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support theming #144

Open
domoritz opened this issue Aug 8, 2019 · 4 comments
Open

Support theming #144

domoritz opened this issue Aug 8, 2019 · 4 comments

Comments

@domoritz
Copy link
Member

domoritz commented Aug 8, 2019

Add support for theming with Vega configs (https://vega.github.io/vega/docs/config/).

@josesaranda
Copy link

josesaranda commented Aug 8, 2019

I think this support require a lot of effort. You can accept the PR for a minor version.

@domoritz
Copy link
Member Author

domoritz commented Aug 8, 2019

I've actually manually set the config before to create a dark mode. It's actually pretty nice.

image

You can find my code at 8a9de43. However, I didn't extract the Vega config into the Falcon config, which I now realize is the right approach.

@josesaranda
Copy link

If you want to add more theming support you can do that, but i only need to change the bar colors at the moment. Please approve it

@domoritz
Copy link
Member Author

domoritz commented Aug 8, 2019

Unfortunately, this change only would introduce backward-incompatible changes once we add support for theming. I don't plan to accept it into the main repo but you can use your fork until theming support lands here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants