Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the conda package noarch #358

Open
martinRenou opened this issue Aug 11, 2021 · 3 comments
Open

Make the conda package noarch #358

martinRenou opened this issue Aug 11, 2021 · 3 comments

Comments

@martinRenou
Copy link

cc. @wolfv

It looks like this package is not noarch on conda-forge, while it could be.

It cannot be noarch yet because of the post-link file that install the nbextension manually. In order to remove this post-link, I suspect you would need to install your vega.json file under the etc/jupyter/nbconfig/notebook.d directory for Jupyter to discover.

For interactive widgets, we usually use data_files for installing this kind of files, see this for example.

Unfortunately, the build tool you are using (poetry) does not support data_files, see this issue, and they don't seem eager to support this feature.

@domoritz
Copy link
Member

Thanks for filing the issue. If you have a suggestion for improving things, I would love a pull request.

@martinRenou
Copy link
Author

I am honestly not sure what the best approach would be, whether this could actually be achieved with poetry or if you would need to choose another build tool.

@domoritz
Copy link
Member

I'm open to other build tools as long as they are easy for me to use. I'd prefer if poetry could add support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants