Skip to content

Commit 518f6ab

Browse files
committed
test: show effect of checking for same dimension and stacked field in both polar and cartesian fields
1 parent ca62a23 commit 518f6ab

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/stack.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,11 @@ export function stack(m: Mark | MarkDef, encoding: Encoding<string>): StackPrope
179179
const hasSameDimensionAndStackedField = dimensionField && dimensionField === stackedField;
180180

181181
// For polar coordinates, do not set a groupBy when working with quantitative fields.
182-
const isPolar = isPolarPositionChannel(fieldChannel) || isPolarPositionChannel(dimensionChannel);
183-
const shouldAddPolarGroupBy = !isUnbinnedQuantitative(dimensionDef);
182+
// const isPolar = isPolarPositionChannel(fieldChannel) || isPolarPositionChannel(dimensionChannel);
183+
// const shouldAddPolarGroupBy = !isUnbinnedQuantitative(dimensionDef);
184184

185-
if (isPolar ? shouldAddPolarGroupBy : !hasSameDimensionAndStackedField) {
185+
if (!hasSameDimensionAndStackedField) {
186+
// if (isPolar ? shouldAddPolarGroupBy : !hasSameDimensionAndStackedField) {
186187
// avoid grouping by the stacked field
187188
groupbyChannels.push(dimensionChannel);
188189
groupbyFields.add(dimensionField);

0 commit comments

Comments
 (0)