File tree Expand file tree Collapse file tree 1 file changed +3
-2
lines changed Expand file tree Collapse file tree 1 file changed +3
-2
lines changed Original file line number Diff line number Diff line change @@ -179,13 +179,14 @@ export function stack(m: Mark | MarkDef, encoding: Encoding<string>): StackPrope
179179 const hasSameDimensionAndStackedField = dimensionField && dimensionField === stackedField ;
180180
181181 // This change breaks cartesian tests, just pushing to start the discussion. When dev'ing locally, try removing this condition.
182+ // TBD: we should only enter this branch if there's also a "color" and maybe a group channel?
182183 const isPolar = isPolarPositionChannel ( fieldChannel ) || isPolarPositionChannel ( dimensionChannel ) ;
183184
184- if ( ! hasSameDimensionAndStackedField && ( isPolar ? dimensionChannel === fieldChannel : true ) ) {
185+ if ( ! hasSameDimensionAndStackedField && ( isPolar ? dimensionChannel === fieldChannel || encoding [ 'color' ] : true ) ) {
185186 // avoid grouping by the stacked field
186187 // TKTK: find out why
187188 groupbyChannels . push ( dimensionChannel ) ;
188- groupbyFields . add ( dimensionField ) ; // Iinvestigate meee
189+ groupbyFields . add ( dimensionField ) ; // Investigate me
189190 }
190191 }
191192
You can’t perform that action at this time.
0 commit comments