Skip to content

Commit cd5a691

Browse files
committed
test: show effect of checking for same dimension and stacked field in both polar and cartesian fields
1 parent ca62a23 commit cd5a691

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

src/stack.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import {array, hasOwnProperty, isBoolean} from 'vega-util';
22
import {Aggregate, SUM_OPS} from './aggregate';
3-
import {getSecondaryRangeChannel, NonPositionChannel, NONPOSITION_CHANNELS, isPolarPositionChannel} from './channel';
3+
import {
4+
getSecondaryRangeChannel,
5+
NonPositionChannel,
6+
NONPOSITION_CHANNELS
7+
// isPolarPositionChannel
8+
} from './channel';
49
import {
510
channelDefType,
611
FieldName,
@@ -179,10 +184,11 @@ export function stack(m: Mark | MarkDef, encoding: Encoding<string>): StackPrope
179184
const hasSameDimensionAndStackedField = dimensionField && dimensionField === stackedField;
180185

181186
// For polar coordinates, do not set a groupBy when working with quantitative fields.
182-
const isPolar = isPolarPositionChannel(fieldChannel) || isPolarPositionChannel(dimensionChannel);
183-
const shouldAddPolarGroupBy = !isUnbinnedQuantitative(dimensionDef);
187+
// const isPolar = isPolarPositionChannel(fieldChannel) || isPolarPositionChannel(dimensionChannel);
188+
// const shouldAddPolarGroupBy = !isUnbinnedQuantitative(dimensionDef);
184189

185-
if (isPolar ? shouldAddPolarGroupBy : !hasSameDimensionAndStackedField) {
190+
if (!hasSameDimensionAndStackedField) {
191+
// if (isPolar ? shouldAddPolarGroupBy : !hasSameDimensionAndStackedField) {
186192
// avoid grouping by the stacked field
187193
groupbyChannels.push(dimensionChannel);
188194
groupbyFields.add(dimensionField);

0 commit comments

Comments
 (0)