Skip to content

Commit fe17a60

Browse files
committed
fix(vega-lite): Improve test util types for test keys
1 parent 84438fd commit fe17a60

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

test-runtime/interval.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {View} from 'vega';
2-
import {SelectionType} from '../src/selection.js';
2+
import {SELECTION_ID, SelectionType} from '../src/selection.js';
33
import {brush, embed, getGeoSpec, getSpec, hits as hitsMaster, tuples} from './util.js';
44
import {describe, expect, it} from 'vitest';
55

test-runtime/region.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
import {TopLevelSpec} from '../src';
2-
import {SELECTION_ID, SelectionType} from '../src/selection';
3-
import {clearRegion, embedFn, circleRegion, polygonRegion, spec, testRenderFn, hits} from './util';
4-
import {Page} from 'puppeteer/lib/cjs/puppeteer/common/Page';
1+
import {TopLevelSpec} from '../src.js';
2+
import {SELECTION_ID, SelectionType} from '../src/selection.js';
3+
import {clearRegion, embedFn, circleRegion, polygonRegion, spec, testRenderFn, hits} from './util.js';
4+
import {Page} from 'puppeteer/lib/cjs/puppeteer/common/Page.js';
5+
6+
// TODO: Rewrite this file with vitest
57

68
describe('region selections at runtime in unit views', () => {
79
let page: Page;

test-runtime/util.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ export function clearRegion(idx: number | {
326326
}
327327

328328
export function multiviewRegion(key: keyof typeof hits.region, idx: number, parent?: string, targetBrush?: boolean) {
329-
// TODO: region clearing will need to support object intake
330329
return key.match('_clear')
331330
? clearRegion(hits.region[key][idx], parent, targetBrush)
332331
: circleRegion(hits.region[key][idx], parent, targetBrush, 10);

0 commit comments

Comments
 (0)