-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
A couple of todos to review/discuss
- DRY
config.yaml
-- our config file is ~500 sloc, a good chunk of it is repetitive or could use templates. A simple QOL improvement would be the ability to split the file into includes with overwrites - Simplify testing -- we need a little guidance but also probably an upstream best practices guide on how to write and maintain event handlers, particularly
- Switch to realistic fixtures (ideally via a VCR-like setup like https://github.com/Netflix/pollyjs or https://github.com/ijpiantanida/talkback)
- Decouple handlers into isolated functions we can unit test, currently we're forced to write integration tests using DB mocking
- DRY handlers to allow reuse of the logic where necessary
Metadata
Metadata
Assignees
Labels
No labels