turbo/no-undeclared-env-vars is slow in 2.5.4

[JavaScriptBach]

Goals

Make turbo/no-undeclared-env-vars fast enough to scale to large codebases.

Non-goals

No response

Background

turbo/no-undeclared-env-vars is slow. I tested 2.5.4 but I'm guessing it's slow in other versions too. Here is some data in terms of total time spent when I run lint on a reasonably large package in my codebase:

Top 20 rules in terms of total time spent:
('turbo/no-undeclared-env-vars', 97291.02774399988)
('@typescript-eslint/no-floating-promises', 41720.97719300006)
('@typescript-eslint/await-thenable', 29344.052659000143)
('@typescript-eslint/no-deprecated', 18512.789870999946)
('@typescript-eslint/no-confusing-void-expression', 11097.768330999967)
('@typescript-eslint/naming-convention', 9752.862801999981)
('import/no-duplicates', 9410.670525999976)
('@typescript-eslint/unbound-method', 7718.753139000007)
('@typescript-eslint/require-await', 7505.618977999983)
('import/order', 7482.702627000018)
('@typescript-eslint/return-await', 4766.320609999989)
('@typescript-eslint/no-unnecessary-condition', 3873.7679010000097)
('@typescript-eslint/no-misused-promises', 3086.0084059999995)
('unicorn/no-array-for-each', 2282.6114619999976)
('unicorn/prefer-at', 2123.186020999999)
('@typescript-eslint/no-restricted-imports', 1459.8851049999987)
('@typescript-eslint/no-unnecessary-type-assertion', 1203.7815760000055)

Turbo is twice as slow as any other lint rule, including typescript-eslint ones that require type information. That seems bad for a rule that shouldn't require type information.

Proposal

I haven't had time to look into where this rule is slow, but if you know where the issue is and can point me to it, I might be able to help write a patch. We use Turbo a good bit so we do have an interest in improving the tooling here.

[anthonyshew]

Hey, @JavaScriptBach, thank you for finding this. This is definitely not good enough.

I've released v2.5.9-canary.7 with #10943 in it. This should dramatically improve performance. Would you be able to give it a try?