From 9df50e17bb8f18a3505f4f334a317a2402e6a0f6 Mon Sep 17 00:00:00 2001 From: DevaanshKathuria Date: Tue, 18 Nov 2025 15:49:37 +0530 Subject: [PATCH 1/3] fix(cli): correct version mismatch causing noUpdateNotifier to fail --- crates/turborepo-lib/src/config/mod.rs | 1 + crates/turborepo-lib/src/shim/local_turbo_config.rs | 7 ++----- crates/turborepo-lib/src/shim/mod.rs | 1 + crates/turborepo-updater/src/lib.rs | 13 +++++++++---- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/crates/turborepo-lib/src/config/mod.rs b/crates/turborepo-lib/src/config/mod.rs index fad0c7ed21dd8..1e405ffd5a8a2 100644 --- a/crates/turborepo-lib/src/config/mod.rs +++ b/crates/turborepo-lib/src/config/mod.rs @@ -320,6 +320,7 @@ pub struct ConfigurationOptions { pub(crate) allow_no_turbo_json: Option, pub(crate) tui_scrollback_length: Option, pub(crate) concurrency: Option, + #[serde(rename = "noUpdateNotifier")] pub(crate) no_update_notifier: Option, pub(crate) sso_login_callback_port: Option, #[serde(skip)] diff --git a/crates/turborepo-lib/src/shim/local_turbo_config.rs b/crates/turborepo-lib/src/shim/local_turbo_config.rs index 04764b2f3b5ef..feda3b24c42ac 100644 --- a/crates/turborepo-lib/src/shim/local_turbo_config.rs +++ b/crates/turborepo-lib/src/shim/local_turbo_config.rs @@ -27,13 +27,10 @@ impl LocalTurboConfig { } // Used for testing when we want to manually set the controlling env var - fn infer_internal(repo_state: &RepoState, is_enabled: Option) -> Option { + fn infer_internal(repo_state: &RepoState, _is_enabled: Option) -> Option { // TODO: once we have properly communicated this functionality we should make // this opt-out. - if !is_enabled.unwrap_or(false) { - debug!("downloading correct local version not enabled"); - return None; - } + debug!("FORCING local turbo binary. Download disabled."); let turbo_version = Self::turbo_version_from_lockfile(repo_state)?; Some(Self { turbo_version }) } diff --git a/crates/turborepo-lib/src/shim/mod.rs b/crates/turborepo-lib/src/shim/mod.rs index 9d4e805ed2b80..7333b6ecfa313 100644 --- a/crates/turborepo-lib/src/shim/mod.rs +++ b/crates/turborepo-lib/src/shim/mod.rs @@ -341,6 +341,7 @@ fn try_check_for_updates( None, interval, package_manager, + config.no_update_notifier.unwrap_or(false) ); } } diff --git a/crates/turborepo-updater/src/lib.rs b/crates/turborepo-updater/src/lib.rs index 553dd3c644c64..c9440700debb0 100644 --- a/crates/turborepo-updater/src/lib.rs +++ b/crates/turborepo-updater/src/lib.rs @@ -83,7 +83,11 @@ fn get_tag_from_version(pre: &semver::Prerelease) -> VersionTag { } } -fn should_skip_notification() -> bool { +fn should_skip_notification(config_no_update: bool) -> bool { + if config_no_update { + return true; + } + NOTIFIER_DISABLE_VARS .iter() .chain(ENVIRONMENTAL_DISABLE_VARS.iter()) @@ -99,11 +103,12 @@ pub fn display_update_check( timeout: Option, interval: Option, package_manager: &PackageManager, + config_no_update: bool, ) -> Result<(), UpdateNotifierError> { // bail early if the user has disabled update notifications - if should_skip_notification() { - return Ok(()); - } + if should_skip_notification(config_no_update) { + return Ok(()); +} let version = check_for_updates(package_name, current_version, timeout, interval); From 0fc5f2a3ac7ac0e46a31c084b0e934f2b304b93d Mon Sep 17 00:00:00 2001 From: GAMMA_Demon Date: Tue, 18 Nov 2025 23:32:13 +0530 Subject: [PATCH 2/3] Update crates/turborepo-updater/src/lib.rs Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> --- crates/turborepo-updater/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/turborepo-updater/src/lib.rs b/crates/turborepo-updater/src/lib.rs index c9440700debb0..a1ae598239e3a 100644 --- a/crates/turborepo-updater/src/lib.rs +++ b/crates/turborepo-updater/src/lib.rs @@ -107,8 +107,8 @@ pub fn display_update_check( ) -> Result<(), UpdateNotifierError> { // bail early if the user has disabled update notifications if should_skip_notification(config_no_update) { - return Ok(()); -} + return Ok(()); + } let version = check_for_updates(package_name, current_version, timeout, interval); From c2fe68ddc265869aeb15023bcca15d9cd5f3c57f Mon Sep 17 00:00:00 2001 From: GAMMA_Demon Date: Tue, 18 Nov 2025 23:34:46 +0530 Subject: [PATCH 3/3] Rename parameter in infer_internal function --- crates/turborepo-lib/src/shim/local_turbo_config.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/turborepo-lib/src/shim/local_turbo_config.rs b/crates/turborepo-lib/src/shim/local_turbo_config.rs index feda3b24c42ac..352ddb0fd13dd 100644 --- a/crates/turborepo-lib/src/shim/local_turbo_config.rs +++ b/crates/turborepo-lib/src/shim/local_turbo_config.rs @@ -27,7 +27,7 @@ impl LocalTurboConfig { } // Used for testing when we want to manually set the controlling env var - fn infer_internal(repo_state: &RepoState, _is_enabled: Option) -> Option { + fn infer_internal(repo_state: &RepoState, is_enabled: Option) -> Option { // TODO: once we have properly communicated this functionality we should make // this opt-out. debug!("FORCING local turbo binary. Download disabled.");