Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very bad contrast on GQL query shown in studio console #770

Closed
johnny-smitherson opened this issue Feb 29, 2024 · 3 comments
Closed

Very bad contrast on GQL query shown in studio console #770

johnny-smitherson opened this issue Feb 29, 2024 · 3 comments
Labels
type/question Type: question about the product

Comments

@johnny-smitherson
Copy link

johnny-smitherson commented Feb 29, 2024

Describe the bug (must be provided)

beforeCapture

green on green makes my eyes hurt

Cap222ture

cannot read these without selecting text in browser

Your Environments (must be provided)

  • OS: Windows 10
  • Node-version: docker nebula-graph-studio:v3.9.1
  • Studio-version: v3.9.1
  • Seen both in Firefox and Chrome

How To Reproduce(must be provided)

  1. Run some console queries
  2. Refresh page
  3. Try to read older queries
  4. bad contrast green on green
Captur2e

Expected behavior

Good contrast, for example after editing in DevConsole with color:#111:

afterCapture

Additional context

proposed CSS changes:

  • color: #111
  • font-family: monospaced
johnny-smitherson added a commit to johnny-smitherson/nebula-studio that referenced this issue Feb 29, 2024
@huaxiabuluo
Copy link
Contributor

@yyh0808

@yyh0808
Copy link
Contributor

yyh0808 commented Mar 4, 2024

Thank you very much for your detailed suggestions!

Regarding colors and fonts, I completely agree with changing the style to a mono font. We originally also hoped to use a mono font for a better development experience.

After using the mono font, the issue of colors being hard to read will improve significantly. However, since you mentioned that the colors still seem a bit painful, we will take your advice and deepen the font color to make the code look more comfortable.

Thank you again for your enthusiastic and detailed suggestions.

@QingZ11 QingZ11 added the type/question Type: question about the product label Mar 4, 2024
@johnny-smitherson
Copy link
Author

johnny-smitherson commented Mar 6, 2024

After discussion in #771 it seems the root cause might be the combination between:

  • the Success/Failure design language (where color is 90% of the message information, e.g. "Sucecess" / "Fail", and where the product has its design guidelines to make it visually consistent)
  • the SQL where the the dots and dashes and syntax highlight colors of the code itself are relevant (and where the programmer is used to design guidelines for code, such as colored, monospace font, high contrast, white background).

I believe this combination does not work in this context. Here are my suggestions, courtesy of mspaint.exe

309706714-6d51e187-edeb-457d-8785-e6ea7f947d46 309706445-d814fad9-d98e-4106-b0d5-5a47dcb6ddf3

Also works with the grey background "can't type into this box" shade:

309706714-6d51e187-edeb-457d-8785-e6ea7f947d46 309706445-d814fad9-d98e-4106-b0d5-5a47dcb6ddf3

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Type: question about the product
Projects
None yet
Development

No branches or pull requests

4 participants