Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linters for the project #24

Closed
sloboegen opened this issue Sep 17, 2023 · 2 comments
Closed

Add linters for the project #24

sloboegen opened this issue Sep 17, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sloboegen
Copy link
Contributor

What do you think about adding several popular linters/formatters for this project, i.e. isort, black, flake8 (or ruff)?

Also, do you want to migrate to poetry from pipenv/tox/...?

@vickumar1981
Copy link
Owner

@sloboegen 👍

i'd like to use black b/c i think it encompasses what flake + pylint were doing before.

for dependency management, i'd really like to use pdm: https://github.com/pdm-project/pdm

But, I'm also okay with using poetry if you think that's an easier approach.

Thanks for opening up this issue.

@vickumar1981 vickumar1981 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 1, 2023
@vickumar1981
Copy link
Owner

Updated to using black as part of: #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants