Skip to content
This repository was archived by the owner on Sep 15, 2023. It is now read-only.
This repository was archived by the owner on Sep 15, 2023. It is now read-only.

wrong generation of path for js-files in rev-manifest on windows #583

Open
@snsttr

Description

@snsttr

On my windows system all js-ressources in the rev-manifest.json have backslashes in their file pathes. This makes it impossible for the craft 3 plugin "craft-asset-rev" to find the correct assertion, since it expects the path with slashes.

Example:
blendid generates
"javascripts\\app.js": "javascripts\\app-040d86f5c824dfce4156.js",
craft-asset-rev would work with
"javascripts/app.js": "javascripts/app-040d86f5c824dfce4156.js",

Possible solution:
The file path is being generated in gulpfile.js/lib/webpackManifest.js by using path.join(...) which generates backslashes for file pathes on windows systems (for original filename and filename with hash). You could just replace backslashes with slashes here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions