psalm removing constructor

[beaneyd-ELS]

Hi,

Can someone help me understand why psalm just removes an entire constructor? It doesn't find a problem with it, but then removes it (see dry-run output). Thanks

╰─>$ ./vendor/bin/psalm --show-info=true src/Service/CustomerPackFilesService.php
Target PHP version: 7.2 (inferred from composer.json)
Scanning files...
Analyzing files...

I

INFO: InvalidNullableReturnType - src/Service/CustomerPackFilesService.php:32:16 - The declared return type 'string' for App\Service\CustomerPackFilesService::getCustomerPackFilesDirectory is not nullable, but 'null|string' contains null (see https://psalm.dev/144)
     * @return string


INFO: MissingParamType - src/Service/CustomerPackFilesService.php:34:83 - Parameter $directory has no provided type (see https://psalm.dev/154)
    public function getCustomerPackFilesDirectory(OutputInterface $output = null, $directory, $server, bool $create = true) {


INFO: NullableReturnStatement - src/Service/CustomerPackFilesService.php:38:24 - The declared return type 'string' for App\Service\CustomerPackFilesService::getCustomerPackFilesDirectory is not nullable, but the function returns 'null' (see https://psalm.dev/139)
                return null;


INFO: PossiblyNullArgument - src/Service/CustomerPackFilesService.php:46:31 - Argument 1 of App\Service\LocalProcess::run cannot be null, possibly null value provided (see https://psalm.dev/078)
            LocalProcess::run($output, "cd $filesDir; git clone [email protected]:sysadm/pack-files.git .");


INFO: PossiblyNullArgument - src/Service/CustomerPackFilesService.php:48:31 - Argument 1 of App\Service\LocalProcess::run cannot be null, possibly null value provided (see https://psalm.dev/078)
            LocalProcess::run($output, "cd $filesDir; git pull");


INFO: MissingParamType - src/Service/CustomerPackFilesService.php:69:78 - Parameter $directory has no provided type (see https://psalm.dev/154)
    public function getCustomerFilesBySuffix(OutputInterface $output = null, $directory, $host, $suffix = null) {


INFO: MissingParamType - src/Service/CustomerPackFilesService.php:69:90 - Parameter $host has no provided type (see https://psalm.dev/154)
    public function getCustomerFilesBySuffix(OutputInterface $output = null, $directory, $host, $suffix = null) {


------------------------------
                              
       No errors found!       
                              
------------------------------
7 other issues found.
------------------------------
Psalm can automatically fix 1 issues.
Run Psalm again with 
--alter --issues=InvalidNullableReturnType --dry-run
to see what it can fix.
------------------------------

Checks took 1.01 seconds and used 511.818MB of memory
Psalm was able to infer types for 90.0000% of the codebase

Altering files...
/home/beaneyd/git/apuma/src/Service/CustomerPackFilesService.php:
--- /home/beaneyd/git/apuma/src/Service/CustomerPackFilesService.php
+++ /home/beaneyd/git/apuma/src/Service/CustomerPackFilesService.php
@@ -17,21 +17,14 @@
     private $ansible;
 
     /**
-     * PackFilesService constructor.
-     * @param AnsibleService $ansible
-     */
-    public function __construct(AnsibleService $ansible) {
-        $this->ansible = $ansible;
-    }
-
-    /**
      * @param OutputInterface|null $output
      * @param $directory
      * @param AbstractHost $server
      * @param bool $create
-     * @return string
+     *
+     * @return null|string
      */
-    public function getCustomerPackFilesDirectory(OutputInterface $output = null, $directory, $server, bool $create = true) {
+    public function getCustomerPackFilesDirectory(OutputInterface $output = null, $directory, $server, bool $create = true): ?string {

[orklah]

Seems like a bug to me