HTML print() is always portable

Author: vincentarelbundock

DESCRIPTION

@@ -2,7 +2,7 @@ Package: tinytable
 Type: Package
 Title: Simple and Configurable Tables in 'HTML', 'LaTeX', 'Markdown', 'Word', 'PNG', 'PDF', and 'Typst' Formats
 Description: Create highly customized tables with this simple and dependency-free package. Data frames can be converted to 'HTML', 'LaTeX', 'Markdown', 'Word', 'PNG', 'PDF', or 'Typst' tables. The user interface is minimalist and easy to learn. The syntax is concise. 'HTML' tables can be customized using the flexible 'Bootstrap' framework, and 'LaTeX' code with the 'tabularray' package.
-Version: 0.15.0.1
+Version: 0.15.0.2
 Imports:
     methods
 Depends:

NEWS.md

@@ -2,6 +2,10 @@
 
 ## 0.15.0.1
 
+Misc:
+
+* `print(tab, "html")` always base 64 encodes images. This is useful because it makes files more portable when viewed in IDEs, and because it simplifies path handling in temporary directories across operating systems.
+
 Bugs:
 
 * Fixed spurious Windows portable HTML warning when using `height` parameter with non-HTML output formats (Issue #608).

R/print.R

@@ -92,10 +92,12 @@ print.tinytable <- function(
   dir <- getOption("tinytable_tempdir", default = tempdir())
   dir <- sub("\\/$", "", dir)
 
-  if (output == "html") {
+  if (identical(output, "html")) {
     x@output_dir <- dir
+    x@html_portable <- TRUE
   }
 
+
   x <- build_tt(x, output = output)
 
   tab <- x@table_string

R/theme_html.R

@@ -67,20 +67,6 @@ theme_html <- function(
   sanity_tabulator_css_rule(tabulator_css_rule)
   sanity_tabulator_columns(tabulator_columns)
 
-  # Defer portable warning check until finalization when output format is known
-  if (isTRUE(Sys.info()["sysname"] == "Windows")) {
-    fn_portable_warning <- function(table) {
-      if (!isTRUE(table@html_portable)) {
-        warning("On Windows, `tinytable` should embed images in the HTML file directly. Set  `theme_html(portable=TRUE)` explicitly to silence this warning.",
-          call. = FALSE
-        )
-      }
-      return(table)
-    }
-    x <- build_finalize(x, fn_portable_warning, output = "html")
-  }
-
-
   if (!is.null(engine)) {
     x@html_engine <- engine
     if (engine == "bootstrap" && is.null(class) && identical(x@html_class, "tinytable")) {
@@ -104,9 +90,6 @@ theme_html <- function(
 
   if (!is.null(portable)) {
     assert_flag(portable)
-    if (isTRUE(portable)) {
-      assert_dependency("base64enc")
-    }
     x@html_portable <- portable
   }