Skip to content

Commit 2ecdb56

Browse files
Merge pull request #71 from vincentwolsink/fix_model_name
Add missing places to expose detected envoy model
2 parents 4b37fc2 + 581ab45 commit 2ecdb56

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

custom_components/enphase_envoy/binary_sensor.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,13 @@ def device_info(self) -> DeviceInfo or None:
141141
"""Return the device_info of the device."""
142142
if not self._device_serial_number:
143143
return None
144+
145+
model = self.coordinator.data.get("envoy_info", {}).get("model", "Standard")
146+
144147
return DeviceInfo(
145148
identifiers={(DOMAIN, str(self._device_serial_number))},
146149
manufacturer="Enphase",
147-
model="Envoy",
150+
model=f"Envoy-S {model}",
148151
name=self._device_name,
149152
)
150153

@@ -202,10 +205,11 @@ def device_info(self) -> DeviceInfo or None:
202205
"""Return the device_info of the device."""
203206
if not self._device_serial_number:
204207
return None
208+
205209
return DeviceInfo(
206210
identifiers={(DOMAIN, str(self._device_serial_number))},
207211
manufacturer="Enphase",
208-
model="Envoy",
212+
model="Inverter",
209213
name=self._device_name,
210214
)
211215

@@ -277,7 +281,11 @@ def device_info(self) -> DeviceInfo | None:
277281
if self._parent_device:
278282
device_info_kw["via_device"] = (DOMAIN, self._parent_device)
279283

280-
if self.MODEL == "Relay":
284+
if self.MODEL == "Envoy":
285+
model = self.coordinator.data.get("envoy_info", {}).get("model", "Standard")
286+
self.MODEL = f"Envoy-S {model}"
287+
288+
elif self.MODEL == "Relay":
281289
info = self.coordinator.data.get("relay_info", {}).get(
282290
self._device_serial_number, {}
283291
)

custom_components/enphase_envoy/sensor.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -253,13 +253,9 @@ def device_info(self) -> DeviceInfo | None:
253253
if not self._device_serial_number:
254254
return None
255255

256-
sw_version = None
257-
hw_version = None
258-
model = None
259-
if self.coordinator.data.get("envoy_info"):
260-
sw_version = self.coordinator.data.get("envoy_info").get("software", None)
261-
hw_version = self.coordinator.data.get("envoy_info").get("pn", None)
262-
model = self.coordinator.data.get("envoy_info").get("model", None)
256+
sw_version = self.coordinator.data.get("envoy_info", {}).get("software", None)
257+
hw_version = self.coordinator.data.get("envoy_info", {}).get("pn", None)
258+
model = self.coordinator.data.get("envoy_info", {}).get("model", "Standard")
263259

264260
return DeviceInfo(
265261
identifiers={(DOMAIN, str(self._device_serial_number))},

custom_components/enphase_envoy/switch.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,13 @@ def device_info(self) -> DeviceInfo or None:
7373
"""Return the device_info of the device."""
7474
if not self._device_serial_number:
7575
return None
76+
77+
model = self.coordinator.data.get("envoy_info", {}).get("model", "Standard")
78+
7679
return DeviceInfo(
7780
identifiers={(DOMAIN, str(self._device_serial_number))},
7881
manufacturer="Enphase",
79-
model="Envoy",
82+
model=f"Envoy-S {model}",
8083
name=self._device_name,
8184
)
8285

0 commit comments

Comments
 (0)