refactor: apply staticcheck

Author: sewnie

cmd/vinegar/bootstrapper_setup_rblx.go

@@ -59,7 +59,7 @@ func (b *bootstrapper) setupDeployment() error {
 	if b.bin.Channel != "" && b.bin.Channel != "LIVE" {
 		b.message("Writing Registry")
 		if err := b.pfx.RegistryAdd(channelKey, "www.roblox.com", b.bin.Channel); err != nil {
-			return fmt.Errorf("set channel reg: %w")
+			return fmt.Errorf("set channel reg: %w", err)
 		}
 	}
 

cmd/vinegar/manager.go

@@ -67,7 +67,7 @@ func (a *app) newManager() *manager {
 		},
 		"run": m.run,
 
-		"prefix-kill":   m.pfx.Kill,
+		"prefix-kill":   m.killPrefix,
 		"delete-prefix": m.deletePrefixes,
 		"delete-studio": m.deleteDeployments,
 		"clear-cache":   m.clearCache,

cmd/vinegar/manager_actions.go

@@ -74,7 +74,6 @@ func (m *manager) saveConfig() {
 	banner.SetTitle(fmt.Sprintf("Invalid: %v", err))
 	banner.SetRevealed(true)
 	slog.Info("Configuration validation error", "err", err)
-	return
 }
 
 func (m *manager) showAbout() {

internal/adwaux/adwaux.go

@@ -4,15 +4,11 @@ package adwaux
 
 import (
 	"reflect"
-	"regexp"
 	"strings"
 
 	"github.com/jwijenbergh/puregotk/v4/adw"
 )
 
-// Transform value names to their Title Case counterparts
-var configNameExp = regexp.MustCompile(`([a-z])([A-Z])`)
-
 type StructPage struct {
 	sv     reflect.Value
 	groups map[string]*adw.PreferencesGroup

internal/netutil/netutil.go

@@ -54,8 +54,7 @@ func DownloadProgress(url, file string, pbar *gtk.ProgressBar) error {
 		pbar:  pbar,
 	}
 
-	var idlecb glib.SourceFunc
-	idlecb = func(uintptr) bool {
+	var idlecb glib.SourceFunc = func(uintptr) bool {
 		pbar.SetFraction(float64(pc.current) / float64(pc.total))
 		return pc.current != pc.total
 	}

internal/studiorpc/studiorpc.go

@@ -11,8 +11,6 @@ import (
 	"github.com/sewnie/rbxweb"
 )
 
-const appID = "1159891020956323923"
-
 type StudioRPC struct {
 	presence drpc.Activity
 	client   *drpc.Client