Feat/wip exceptions (#65)

* feat: add some exceptions

* feat: get rid of system exits from the code

The code should throw exceptions instead of halting the execution of
programs. Tests are also updated to account for this change.

- Github Issue: #64

Authored-by: Vinit Kumar <[email protected]>
Signed-off-by: Vinit Kumar <[email protected]>

* feat: bump version

Author: vinitkumar

json2xml/__init__.py

@@ -4,7 +4,7 @@
 
 __author__ = """Vinit Kumar"""
 __email__ = "[email protected]"
-__version__ = "3.5.0"
+__version__ = "3.6.0"
 
 
 # from .utils import readfromurl, readfromstring, readfromjson

json2xml/utils.py

@@ -1,9 +1,21 @@
 """Utils methods to convert XML data to dict from various sources"""
-import sys
 import json
 import requests
 
 
+class JSONReadError(Exception):
+    pass
+
+
+class URLReadError(Exception):
+    pass
+
+
+class StringReadError(Exception):
+    pass
+
+
+
 def readfromjson(filename: str) -> dict:
     """
     Reads a json string and emits json string
@@ -15,10 +27,10 @@ def readfromjson(filename: str) -> dict:
         return data
     except ValueError as exp:
         print(exp)
-        sys.exit(exp)
+        raise JSONReadError
     except IOError as exp:
         print(exp)
-        sys.exit(exp)
+        raise JSONReadError("Invalid JSON File")
 
 
 def readfromurl(url: str, params: dict = None) -> dict:
@@ -29,21 +41,21 @@ def readfromurl(url: str, params: dict = None) -> dict:
     if response.status_code == 200:
         data = response.json()
         return data
-    sys.exit(response.text)
+    raise URLReadError("URL is not returning correct response")
 
 
 def readfromstring(jsondata: str) -> dict:
     """
     Loads json from string
     """
     if not isinstance(jsondata, str):
-        sys.exit("the input doesn't seem to be valid string")
+        raise StringReadError("Sorry! the string doesn't seems to a proper JSON")
     try:
         data = json.loads(jsondata)
     except ValueError as exp:
         print(exp)
-        sys.exit(exp)
+        raise StringReadError("Sorry! the string doesn't seems to a proper JSON")
     except Exception as exp:
         print(exp)
-        sys.exit(exp)
+        raise StringReadError("Sorry! the string doesn't seems to a proper JSON")
     return data

tests/test_json2xml.py

@@ -10,7 +10,7 @@
 import xmltodict
 
 from json2xml import json2xml
-from json2xml.utils import readfromjson, readfromstring, readfromurl
+from json2xml.utils import readfromjson, readfromstring, readfromurl, JSONReadError, StringReadError, URLReadError
 
 
 class TestJson2xml(unittest.TestCase):
@@ -29,22 +29,18 @@ def test_read_from_json(self):
 
     def test_read_from_invalid_json(self):
         """Test something."""
-        with pytest.raises(SystemExit) as pytest_wrapped_e:
+        with pytest.raises(JSONReadError) as pytest_wrapped_e:
             data = readfromjson("examples/licht_wrong.json")
-        assert pytest_wrapped_e.type == SystemExit
+        assert pytest_wrapped_e.type == JSONReadError
 
     def test_read_from_url(self):
         data = readfromurl("https://coderwall.com/vinitcool76.json")
         assert type(data) is dict
 
     def test_read_from_wrong_url(self):
-        """
-        Use wrong url and check if there is a sytemExit
-        """
-        with pytest.raises(SystemExit) as pytest_wrapped_e:
+        with pytest.raises(URLReadError) as pytest_wrapped_e:
             data = readfromurl("https://coderwall.com/vinitcool76.jsoni")
-        print("type is ", pytest_wrapped_e.type)
-        assert pytest_wrapped_e.type == SystemExit
+        assert pytest_wrapped_e.type == URLReadError
 
     def test_read_from_jsonstring(self):
         data = readfromstring(
@@ -53,11 +49,11 @@ def test_read_from_jsonstring(self):
         assert type(data) is dict
 
     def test_read_from_invalid_jsonstring(self):
-        with pytest.raises(SystemExit) as pytest_wrapped_e:
+        with pytest.raises(StringReadError) as pytest_wrapped_e:
             data = readfromstring(
                 '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"'
             )
-        assert pytest_wrapped_e.type == SystemExit
+        assert pytest_wrapped_e.type == StringReadError
 
     def test_json_to_xml_conversion(self):
         data = readfromstring(