refactor: use set in get_unique_id

Author: vinitkumar

json2xml/dicttoxml.py

@@ -39,25 +39,13 @@ def make_id(element: str, start: int = 100000, end: int = 999999) -> str:
 
 
 def get_unique_id(element: str) -> str:
-    """
-    Generate a unique ID for a given element.
-
-    Args:
-        element (str): The element to generate an ID for.
-
-    Returns:
-        str: The unique ID.
-    """
-    ids: list[str] = []  # initialize list of unique ids
-    this_id = make_id(element)
-    dup = True
-    while dup:
-        if this_id not in ids:
-            dup = False
-            ids.append(this_id)
-        else:
-            this_id = make_id(element)
-    return ids[-1]
+    """Generate a unique ID for a given element using a set for efficiency."""
+    ids: set[str] = set()
+    while True:
+        new_id = make_id(element)
+        if new_id not in ids:
+            ids.add(new_id)
+            return new_id
 
 
 ELEMENT = Union[