Merge pull request #2 from vinitkumar/feat/add-github-actions-ci

Feat/add GitHub actions ci

Author: vinitkumar

.github/workflows/ci.yml

@@ -0,0 +1,82 @@
+name: Go CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+    name: Test
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: '1.24.3'
+        cache: true
+
+    - name: Run tests
+      run: go test -v ./...
+
+  build:
+    name: Build
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: '1.24.3'
+        cache: true
+
+    - name: Build
+      run: go build -v -o pdf-joiner
+
+    - name: Upload artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: pdf-joiner
+        path: pdf-joiner
+
+  release:
+    name: Release
+    needs: [test, build]
+    if: startsWith(github.ref, 'refs/tags/v')
+    runs-on: macos-latest
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: '1.24.3'
+
+    - name: Build
+      run: go build -v -o pdf-joiner
+
+    - name: Create Release
+      id: create_release
+      uses: actions/create-release@v1
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        tag_name: ${{ github.ref }}
+        release_name: Release ${{ github.ref }}
+        draft: false
+        prerelease: false
+
+    - name: Upload Release Asset
+      id: upload-release-asset
+      uses: actions/upload-release-asset@v1
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        upload_url: ${{ steps.create_release.outputs.upload_url }}
+        asset_path: ./pdf-joiner
+        asset_name: pdf-joiner
+        asset_content_type: application/octet-stream

.github/workflows/golangci-lint.yml

@@ -0,0 +1,25 @@
+name: golangci-lint
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+permissions:
+  contents: read
+  # Optional: allow read access to pull request. Use with `only-new-issues` option.
+  # pull-requests: read
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: stable
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: v2.1

.gitignore

@@ -0,0 +1,28 @@
+# Binaries for programs and plugins
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+pdf-joiner
+
+# Test binary, built with `go test -c`
+*.test
+
+# Output of the go coverage tool
+*.out
+
+# Dependency directories (remove the comment below if you'll be checking in your vendor directory)
+# vendor/
+
+# Go workspace file
+go.work
+
+# macOS specific files
+.DS_Store
+
+# IDE files
+.idea/
+.vscode/
+*.swp
+*.swo 

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2025 Vinit Kumar
+Copyright (c) 2023 Vinit Kumar
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,90 +1,62 @@
 # PDF Joiner
 
-A simple command-line utility for joining multiple PDF files into a single PDF document on macOS.
+[![Go CI](https://github.com/vinitkumar/pdf-joiner/actions/workflows/ci.yml/badge.svg)](https://github.com/vinitkumar/pdf-joiner/actions/workflows/ci.yml)
+
+A simple command-line tool to join multiple PDF files into a single PDF document on macOS.
 
 ## Requirements
 
-- macOS (This tool uses the built-in macOS PDF joining utility)
-- Go 1.18 or later (for building from source)
+- macOS (the tool uses the built-in macOS PDF joining utility)
+- Go 1.24 or higher (for development)
 
 ## Installation
 
 ### From Source
 
-1. Clone this repository:
-   ```
-   git clone https://github.com/vinitkumar/pdf-joiner.git
-   cd pdf-joiner
-   ```
-
-2. Build the binary:
-   ```
-   make build
-   ```
-
-3. (Optional) Install the binary to your system:
-   ```
-   make install
-   ```
-
-## Usage
-
+```bash
+git clone https://github.com/vinitkumar/pdf-joiner.git
+cd pdf-joiner
+go build -o pdf-joiner
 ```
-pdf-joiner [-o output.pdf] file1.pdf file2.pdf [file3.pdf ...]
-```
-
-### Options
 
-- `-o`: Specify the output file path. If not provided, the output will be saved as `joined-pdf-YYYY-MM-DD-HHMMSS.pdf` in the current directory.
+### From Releases
 
-### Examples
+Download the latest binary from the [Releases page](https://github.com/vinitkumar/pdf-joiner/releases).
 
-Join two PDF files:
-```
-pdf-joiner file1.pdf file2.pdf
-```
+## Usage
 
-Join multiple PDF files with a specific output path:
-```
-pdf-joiner -o merged.pdf file1.pdf file2.pdf file3.pdf
-```
+```bash
+# Join PDFs with default output filename (timestamp-based)
+./pdf-joiner file1.pdf file2.pdf file3.pdf
 
-Join all PDF files in a directory:
-```
-pdf-joiner -o merged.pdf /path/to/directory/*.pdf
+# Join PDFs with a custom output filename
+./pdf-joiner -o output.pdf file1.pdf file2.pdf file3.pdf
 ```
 
-## How It Works
+## Features
 
-This tool is a wrapper around the macOS built-in PDF joining utility located at:
-```
-/System/Library/Automator/Combine PDF Pages.action/Contents/MacOS/join
-```
+- Join multiple PDF files into a single document
+- Specify custom output path
+- Automatic output filename generation with timestamp
+- Verification of input files
 
 ## Development
 
-### Running Tests
+### Testing
 
-```
-make test
+```bash
+go test -v ./...
 ```
 
-### Building for Different Architectures
+### Building
 
-Build for both Intel and Apple Silicon Macs:
-```
-make build-universal-darwin
-```
-
-### Cleaning Up
-
-```
-make clean
+```bash
+go build -o pdf-joiner
 ```
 
 ## License
 
-MIT. See the `LICENSE` file for more details.
+MIT
 
 ## Author
 

go.mod

@@ -1,3 +1,3 @@
 module github.com/vinitkumar/pdf-joiner
 
-go 1.24.0
+go 1.24.3

go.sum

@@ -12,8 +12,14 @@ func TestFileExists(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Failed to create temporary file: %v", err)
 	}
-	defer os.Remove(tempFile.Name())
-	defer tempFile.Close()
+	defer func() {
+		if err := tempFile.Close(); err != nil {
+			t.Logf("Failed to close temporary file: %v", err)
+		}
+		if err := os.Remove(tempFile.Name()); err != nil {
+			t.Logf("Failed to remove temporary file: %v", err)
+		}
+	}()
 
 	// Test cases
 	tests := []struct {
@@ -52,25 +58,29 @@ func TestFileExists(t *testing.T) {
 func TestOutputPathGeneration(t *testing.T) {
 	// This is a mock test to demonstrate how we would test the output path generation
 	// In a real test, we would need to mock time.Now() or use dependency injection
-	
+
 	// Create a temporary directory for testing
 	tempDir, err := os.MkdirTemp("", "pdf-joiner-test")
 	if err != nil {
 		t.Fatalf("Failed to create temporary directory: %v", err)
 	}
-	defer os.RemoveAll(tempDir)
-	
+	defer func() {
+		if err := os.RemoveAll(tempDir); err != nil {
+			t.Logf("Failed to remove temporary directory: %v", err)
+		}
+	}()
+
 	// Test that we can create directories for output
 	testOutputPath := filepath.Join(tempDir, "subdir", "output.pdf")
 	outputDir := filepath.Dir(testOutputPath)
-	
+
 	err = os.MkdirAll(outputDir, 0755)
 	if err != nil {
 		t.Errorf("Failed to create output directory: %v", err)
 	}
-	
+
 	// Verify the directory was created
 	if _, err := os.Stat(outputDir); os.IsNotExist(err) {
 		t.Errorf("Output directory was not created: %v", err)
 	}
-} 
+}