Skip to content

Double the number of silent samples may be written per SilentAudioFrame packet received. #1708

Open
@ctrlaltdavid

Description

@ctrlaltdavid

The value being passed into InboundAudioStream::writeDroppableSilentFrames(int silentFrames) is the number of silent samples (480 for stereo), not the number of silent frames (240 for stereo). The code then doubles this number for stereo to calculate the number of silent samples.

The result is that too much silence is added. However, because silence is only added if the jitter buffer is less than its desirable size, typically the extra silence will be discarded (dropped) and not written.

A benign bug but confusing code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingstaleIssue / PR has not had activity

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions