You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should have consistent, useful and well-formed data-testids on all elements Virtuoso exports
Describe the solution you'd like
Right now I have manually added data-testids to a few things. We either need to do this for all elements, or add some kind of programatic tagging. (If testIds could be automatically injected with metadata about whatever thing instantiated virtuoso, such as "data-testid=dashboardv2-VDS-tablecell", that could be useful but is not required).
If there's no clean way to do this programmatically, then we need to add good selectors to everything as we would with any other front end code. A specific concern I have right now is that I am tagging tablerows and cells with "VDS-tablerow" etc, and nothing else, and it may be useful to add an additional id that provides more information about what that cell is/contains, to avoid messier use in test code.
Describe alternatives you've considered
There's no good alternative; Virtuoso is generating the frontend code and tags so it needs to be the origin of these tags, as well.
The text was updated successfully, but these errors were encountered:
🚀 feature request
Description
We should have consistent, useful and well-formed data-testids on all elements Virtuoso exports
Describe the solution you'd like
Right now I have manually added data-testids to a few things. We either need to do this for all elements, or add some kind of programatic tagging. (If testIds could be automatically injected with metadata about whatever thing instantiated virtuoso, such as "data-testid=dashboardv2-VDS-tablecell", that could be useful but is not required).
If there's no clean way to do this programmatically, then we need to add good selectors to everything as we would with any other front end code. A specific concern I have right now is that I am tagging tablerows and cells with "VDS-tablerow" etc, and nothing else, and it may be useful to add an additional id that provides more information about what that cell is/contains, to avoid messier use in test code.
Describe alternatives you've considered
There's no good alternative; Virtuoso is generating the frontend code and tags so it needs to be the origin of these tags, as well.
The text was updated successfully, but these errors were encountered: