Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better selectors, either globally, or starting with tables #136

Open
ttdmayshark opened this issue Mar 15, 2021 · 1 comment
Open

add better selectors, either globally, or starting with tables #136

ttdmayshark opened this issue Mar 15, 2021 · 1 comment
Assignees

Comments

@ttdmayshark
Copy link
Contributor

🚀 feature request

Description

We should have consistent, useful and well-formed data-testids on all elements Virtuoso exports

Describe the solution you'd like

Right now I have manually added data-testids to a few things. We either need to do this for all elements, or add some kind of programatic tagging. (If testIds could be automatically injected with metadata about whatever thing instantiated virtuoso, such as "data-testid=dashboardv2-VDS-tablecell", that could be useful but is not required).

If there's no clean way to do this programmatically, then we need to add good selectors to everything as we would with any other front end code. A specific concern I have right now is that I am tagging tablerows and cells with "VDS-tablerow" etc, and nothing else, and it may be useful to add an additional id that provides more information about what that cell is/contains, to avoid messier use in test code.

Describe alternatives you've considered

There's no good alternative; Virtuoso is generating the frontend code and tags so it needs to be the origin of these tags, as well.

@avkvirtru
Copy link
Contributor

Pending larger discussion about using an existing React component library as the underpinnings of the Virtuoso Design System.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants