Skip to content

Commandline mode need some work #255

@sunnyking

Description

@sunnyking

a) The most notable issue is that the current jar build lacks commandline options to overwrite default configuration similar to how bitcoind works. The preferred behavior is to allow all configuration parameters be overwriteable in a popular style, for example --rest-api.bind-address=0.0.0.0.

b) The commandline api request via curl, doesn't get a closing newline after the json text, which misaligns the terminal prompt.

ubuntu@zemyna:~$ curl http://127.0.0.1:9922/blocks/height
{
  "height" : 186425
}ubuntu@zemyna:~$ 

detail, but still important to get right.

c) As we have switched to mainnet configuration as default, the following log message is no longer appropriate:

2021-01-02 03:51:48 WARN  [main] vsys.Application$ - NO CONFIGURATION FILE WAS PROVIDED. STARTING WITH DEFAULT SETTINGS FOR TESTNET!

I would suggest it to be changed to No configuration file provided, starting with default settings.

d) Maybe I am missing something here, but the handshake log is a bit hard to understand:

2021-01-02 04:31:38 INFO  [ntLoopGroup-3-2] vsys.network.NetworkServer - [78dbadda 3.104.62.227:9921] Connection established
2021-01-02 04:31:39 INFO  [ntLoopGroup-3-2] v.n.HandshakeHandler$Client - [78dbadda 3.104.62.227:9921] Accepted handshake Handshake(V SYSTEMSM,(0,3,2),Node-306365,306365,Some(/127.0.0.1:9921))
2021-01-02 04:32:03 INFO  [ntLoopGroup-3-3] vsys.network.NetworkServer - [597e59f3 54.95.22.119:9921] Connection established
2021-01-02 04:32:03 INFO  [ntLoopGroup-3-3] v.n.HandshakeHandler$Client - [597e59f3 54.95.22.119:9921] Accepted handshake Handshake(V SYSTEMSM,(0,3,1),NEOPLY Fullnode 2,19095,Some(/54.95.22.119:9921))
2021-01-02 04:32:13 INFO  [ntLoopGroup-3-1] vsys.network.NetworkServer - [854c0d97 13.52.40.227:9921] Connection established
2021-01-02 04:32:13 INFO  [ntLoopGroup-3-1] v.n.HandshakeHandler$Client - [854c0d97 13.52.40.227:9921] Accepted handshake Handshake(V SYSTEMSM,(0,3,2),Node-409094,409094,Some(/127.0.0.1:9921))

3 nodes were connected here, but the middle one shows a handshake Some(/54.95.22.119:9921) but the other two shows Some(/127.0.0.1:9921)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions