Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/200 create a cef server file with builds #201

Open
wants to merge 11 commits into
base: development
Choose a base branch
from
Open

Feature/200 create a cef server file with builds #201

wants to merge 11 commits into from

Conversation

franzTobiasDLR
Copy link
Member

@franzTobiasDLR franzTobiasDLR commented Nov 20, 2023 •
edited
Loading

Currently, only VirSat_Core provides a server, with this PR we will also create a server for more specific applications

@franzTobiasDLR franzTobiasDLR linked an issue Nov 20, 2023 that may be closed by this pull request
Create a CEF server file with builds #200
Open
@franzTobiasDLR franzTobiasDLR changed the title WIP: Feature/200 create a cef server file with builds Feature/200 create a cef server file with builds Nov 21, 2023
pchrszon-dlr
pchrszon-dlr approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@pchrszon-dlr pchrszon-dlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the absolute path in the launch configuration (which might not be an issue), everything looks fine to me.

launch/VirSat CEF Headless Server.launch Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Merging #201 (f98b684) into development (a27bf91) will not change coverage.
The diff coverage is n/a.

❗ Current head f98b684 differs from pull request most recent head 3ed28b1. Consider uploading reports for the commit 3ed28b1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #201   +/-   ##
==============================================
  Coverage          88.00%   88.00%           
  Complexity           518      518           
==============================================
  Files                 74       74           
  Lines               1750     1750           
  Branches             217      217           
==============================================
  Hits                1540     1540           
  Misses               134      134           
  Partials              76       76
Files Coverage Δ
...l/extension/cef/interfaces/model/BusInterface.java 100.00% <ø> (ø)
...tension/cef/interfaces/model/DataInterfaceEnd.java 100.00% <ø> (ø)
.../interfaces/model/DataInterfaceTypeCollection.java 100.00% <ø> (ø)
...nsion/cef/interfaces/model/DataInterfaceTypes.java 100.00% <ø> (ø)
.../cef/interfaces/model/EquipmentDataParameters.java 100.00% <ø> (ø)
...on/cef/interfaces/model/PointToPointInterface.java 100.00% <ø> (ø)
...ension/cef/interfaces/model/PowerInterfaceEnd.java 100.00% <ø> (ø)
.../sc/virsat/model/extension/cef/model/Document.java 100.00% <ø> (ø)
...sc/virsat/model/extension/cef/model/Equipment.java 100.00% <ø> (ø)
...l/extension/cef/model/EquipmentMassParameters.java 100.00% <ø> (ø)
... and 30 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchrszon-dlr pchrszon-dlr pchrszon-dlr approved these changes

@dellerDLR dellerDLR dellerDLR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a CEF server file with builds
3 participants
@franzTobiasDLR @dellerDLR @pchrszon-dlr