Markers - Multiple Fixes

[adrian-moisa]

VE Markers - Controller method: highlightMarker() #139

We want to be able to trigger from the controller the highlight behaviour for markers (and highlights if we are doing already for markers). Update doc page to document this new method. Add demo page.

VE Markers - Marker attachments for blocks #147

• Marker attachments no longer work in text that was indented. That is because indented text is rendered as a block. The same code that handles rendering of markers in
• The documentBlocsAndLines() needs to be updated to extract markers from the blocks as well. Keep in mind that block contain editable lines so most of the code is already there. It just needs to be "hooked up".

Screen.Recording.2022-09-30.at.19.44.43.mov

Automatic testing is mandatory

VE Markers - New markers can override existing markers #142 CRITICAL

If the text selection perfectly matches a marker then the dropdown works fine. However if the selection does not overall the marker then no layers are displayed. This is probably happening because the rules for the other styles are different. If you select text that is partly bold partly regular, then the bold button is not highlighted. Meaning that when you click it you have the option to add bold. I believe this behaviour is rather logical and should not change.

Screen.Recording.2022-09-30.at.16.10.22.mov

New Markers override existing markers
Related to the same behaviour. If we select text that contains a marker inside then when we attempt to add a new marker, the old one or old ones get discarded and the new marker is added. This behaviour is unacceptable for VS. We can't simply lose metadata because the editor overrode the markers and therefore we lost the internal UUID that linked the markers to the metadata objects.

As you can see in this demo, we are not supposed to lose old markers.

Screen.Recording.2022-09-30.at.16.09.05.mov

VE Markers - Tapping the same marker twice type in toolbar, adds it again #219

VE Markers - Each change of style adds a new attachment for the same marker #137

This behaviour happens because the markers get split in children nodes, each one containing a unique combination of styles. We need to track them by id such that we render only once. When the EditableTextLineRenderer collects the marker dat we need to keep a list of markers that have been cached. We need to cach only the first fragment of each unique id. Markers are already built to with unique ids by default.

Screen.Recording.2022-09-30.at.15.24.03.mov

VE Markers - Typing in markers creates additional rectangles #143

When typing new characters in the body of a marker, we see some odd behaviour. For some reason the new characters get their own marker rectangle. I don't have a theory from where it comes so we will have to use the good old method of printing from step to step to see why the new chars get inserted as characters. Automatic testing is mandatory.

Screen.Recording.2022-09-30.at.18.03.29.mov

VE Markers - Disable hidden markers rectangles calculation PERF

If we don't show markers attachments for hidden marker types, disable marker calculation PERF

VE Markers - Keep markers attachments visible when the markers are hidden #136

Currently when using the _controller.toggleMarkers() method we also lose the ability to render the marker attachments. We would like to keep rendering the marker attachments while hiding the markers. This would be possible by skipping the draw call.

Screen.Recording.2022-11-05.at.16.05.22.mov

VE Markers - Quick menu not working on double tap #186

• Tapping fast on marker/highlight does not show menu
• Possibly because the hover is not yet detected?
• It looks like this delay already exists for selection completed (since we added the post build event).
• Looking at the console log to trace the build, paint and display menu calls, it appears there's no extra "unexpected" work in between.
• So it appears that we might not be able to do anything about it for the development build.
• Double tapping a word does not emit the selection completed event. Therefore the selection menu disappear because always the last event will be selecting changed which is wired to call hideMenu()