Document - Undo, Redo Fixes

[adrian-moisa]

VE Document - Not all changes respond to the undo hotkey #50

• Pressing Cmd+Z wont unde the addition of checkboxes in text. However it restored bold styles. Many such situations occur. Not sure yet what is the root cause. Needs investigation.
• Undo does not restore styling changes, only character content edits are restored. Apparently the undo feature works for styles only by pressing the undo redo buttons. Not from the keyboard. Only changing characters works from keyboard. That is sign of some bad architecture. The behaviours should be matching at all times. This is issue that I've inherited from Flutter Quill when forking it.

Screen.Recording.2022-05-20.at.12.43.13.mov

VE Document - Cursor gets moved around when undoing and redoing

VE Document - Keyboard hotkey loses styling when restoring text #52

• Toolbar undo button and Command Z act differently. Keyboard hotkey loses styling when restoring text. The behaviours should be identical.
• Some sample code if useful:

      RawKeyboardListener(
        focusNode: FocusNode(),
        onKey: (event) {
          if (event.data.isControlPressed && event.character == 'b') {
            if (_controller!
                .getSelectionStyle()
                .attributes
                .keys
                .contains('bold')) {
              _controller!.formatSelection(
                AttributeM.clone(AttributeM.bold, null),
              );
            } else {
              _controller!.formatSelection(AttributeM.bold);
            }
          }
        },
        child: _editor(),
      ),