fix: duplicate HAProxy IPs in connection info (#1208)

Author: vitabaks

automation/molecule/tests/roles/deploy-finish/variables/haproxy_nodes.yml

@@ -15,7 +15,7 @@
         groups['balancers']
         | default([])
         | map('extract', hostvars, 'inventory_hostname')
-        | join(',')
+        | join(', ')
       }}
 
 # 🖨️ Debugging the established haproxy_nodes
@@ -32,7 +32,7 @@
     that:
       - "haproxy_nodes is not none"
       - "haproxy_nodes != 'N/A'"
-      - "haproxy_nodes == 'una.name,10.172.0.21,10.172.0.22'"
+      - "haproxy_nodes == 'una.name, 10.172.0.21, 10.172.0.22'"
     fail_msg: "Test failed: haproxy_nodes is not set correctly."
     success_msg: "Test passed: haproxy_nodes is set correctly."
 
@@ -49,7 +49,7 @@
         groups['postgres_cluster']
         | default([])
         | map('extract', hostvars, 'inventory_hostname')
-        | join(',')
+        | join(', ')
       }}
 
 # 🖨️ Debugging the established postgres_cluster_nodes
@@ -66,6 +66,6 @@
     that:
       - "postgres_cluster_nodes is not none"
       - "postgres_cluster_nodes != 'N/A'"
-      - "postgres_cluster_nodes == 'una.name,10.172.0.21,10.172.0.22'"
+      - "postgres_cluster_nodes == 'una.name, 10.172.0.21, 10.172.0.22'"
     fail_msg: "Test failed: postgres_cluster_nodes is not set correctly."
     success_msg: "Test passed: postgres_cluster_nodes is set correctly."

automation/roles/deploy_finish/tasks/main.yml

@@ -146,13 +146,23 @@
       when: not with_haproxy_load_balancing | bool and not pgbouncer_install | bool
   ignore_errors: true
   vars:
-    public_haproxy_ip_addresses: "{{ groups['balancers'] | default([]) | map('extract', hostvars, 'ansible_ssh_host') | join(',') }}"
-    public_postgres_ip_addresses: "{{ groups['postgres_cluster'] | default([]) | map('extract', hostvars, 'ansible_ssh_host') | join(',') }}"
-    haproxy_ip_addresses: "{{ groups['balancers'] | default([]) | map('extract', hostvars) | map(attribute='haproxy_bind_address', default=bind_address) | join(',') }}"
-    postgres_ip_addresses: "{{ groups['postgres_cluster'] | default([]) | map('extract', hostvars) | map(attribute='patroni_bind_address', default=bind_address) | join(',') }}"
+    public_haproxy_ip_addresses: "{{ groups['balancers'] | default([]) | map('extract', hostvars, 'ansible_ssh_host') | join(', ') }}"
+    public_postgres_ip_addresses: "{{ groups['postgres_cluster'] | default([]) | map('extract', hostvars, 'ansible_ssh_host') | join(', ') }}"
+    haproxy_ip_addresses: >-
+      {{
+        (groups['balancers'] | default([]) | map('extract', hostvars, 'haproxy_bind_address') | map('default', None, True) | list)
+        | zip(groups['balancers'] | default([]) | map('extract', hostvars, 'bind_address') | map('default', None, True) | list)
+        | map('list') | map('select', 'truthy') | map('first') | unique | join(', ')
+      }}
+    postgres_ip_addresses: >-
+      {{
+        (groups['postgres_cluster'] | default([]) | map('extract', hostvars, 'patroni_bind_address') | map('default', None, True) | list)
+        | zip(groups['postgres_cluster'] | default([]) | map('extract', hostvars, 'bind_address') | map('default', None, True) | list)
+        | map('list') | map('select', 'truthy') | map('first') | unique | join(', ')
+      }}
     superuser_username: "{{ patroni_superuser_username }}"
     superuser_password: "{{ '********' if mask_password | default(false) | bool else patroni_superuser_password }}"
-    libpq_postgres_host_port: "{{ postgres_ip_addresses.split(',') | map('regex_replace', '$', ':' + postgresql_port | string) | join(',') }}"
+    libpq_postgres_host_port: "{{ postgres_ip_addresses.split(',') | map('regex_replace', '$', ':' + postgresql_port | string) | join(', ') }}"
     libpq_load_balance: "{{ '&load_balance_hosts=random' if postgresql_version | int >= 16 else '' }}"
   when:
     - (cluster_vip is not defined or cluster_vip | length < 1)