Complete fix: Add missing PGPASSWORD environment variables to all remaining psql commands

Co-authored-by: vitabaks <[email protected]>

Author: Copilot

automation/roles/update/tasks/update_extensions.yml

@@ -5,6 +5,8 @@
     "select extname from pg_extension e
     join pg_available_extensions ae on extname = ae.name
     where installed_version <> default_version"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   register: pg_old_extensions
   changed_when: false
   check_mode: false
@@ -25,6 +27,8 @@
   ansible.builtin.command: >-
     {{ postgresql_bin_dir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d {{ pg_target_dbname }} -tAXc
     "ALTER EXTENSION {{ item }} UPDATE"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   ignore_errors: true
   loop: "{{ pg_old_extensions.stdout_lines | reject('match', '^pg_repack$') | list }}"
   register: pg_old_extensions_update_result
@@ -42,6 +46,8 @@
       ansible.builtin.command: >-
         {{ postgresql_bin_dir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d {{ pg_target_dbname }} -tAXc
         "ALTER EXTENSION {{ item }} UPDATE"
+      environment:
+        PGPASSWORD: "{{ patroni_superuser_password }}"
       ignore_errors: true
       loop: "{{ pg_old_extensions.stdout_lines | reject('match', '^(pg_repack|pg_stat_statements|pg_stat_kcache)$') | list }}"
       register: pg_old_extensions_update_result
@@ -53,6 +59,8 @@
         "DROP EXTENSION pg_stat_statements CASCADE;
         CREATE EXTENSION pg_stat_statements;
         CREATE EXTENSION pg_stat_kcache"
+      environment:
+        PGPASSWORD: "{{ patroni_superuser_password }}"
   when:
     - patroni_leader_result.status == 200
     - not ansible_check_mode
@@ -66,6 +74,8 @@
     {{ postgresql_bin_dir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d {{ pg_target_dbname }} -tAXc
     "DROP EXTENSION pg_repack;
     CREATE EXTENSION pg_repack;"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   when:
     - patroni_leader_result.status == 200
     - not ansible_check_mode

automation/roles/upgrade/tasks/extensions.yml

@@ -3,6 +3,8 @@
   ansible.builtin.command: >-
     {{ pg_new_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "select datname from pg_catalog.pg_database where datname <> 'template0'"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   register: databases_list
   until: databases_list is success
   delay: 5

automation/roles/upgrade/tasks/initdb.yml

@@ -41,6 +41,8 @@
   ansible.builtin.command: >-
     {{ pg_old_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "select rolname from pg_roles where oid = 10"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   changed_when: false
   register: pg_install_user
   when:
@@ -61,6 +63,8 @@
         current_setting('server_encoding') as server_encoding,
         current_setting('data_checksums') as data_checksums
     ) pg_settings"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   changed_when: false
   register: pg_settings
   when:

automation/roles/upgrade/tasks/pgbouncer_pause.yml

@@ -78,7 +78,7 @@
       pgb_paused_count=0
 
       # wait for the active queries to complete on pg_servers
-      IFS=$'\n' pg_slow_active_counts=($(echo -e "$pg_servers" | xargs -I {} -P "$pg_servers_count" -n 1 ssh -o StrictHostKeyChecking=no {} "psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc \"$pg_slow_active_count_query\""))
+      IFS=$'\n' pg_slow_active_counts=($(echo -e "$pg_servers" | xargs -I {} -P "$pg_servers_count" -n 1 ssh -o StrictHostKeyChecking=no {} "PGPASSWORD='{{ patroni_superuser_password }}' psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc \"$pg_slow_active_count_query\""))
 
       # sum up all the values in the array
       total_pg_slow_active_count=0
@@ -109,7 +109,7 @@
       # after 30 seconds of waiting, terminate active sessions on pg_servers and try pausing again
       if (( current_time - start_time >= {{ pgbouncer_pool_pause_terminate_after }} )); then
         echo "$(date): terminate active queries"
-        echo -e "$pg_servers" | xargs -I {} -P "$pg_servers_count" -n 1 ssh -o StrictHostKeyChecking=no {} "psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc \"$pg_slow_active_terminate_query\""
+        echo -e "$pg_servers" | xargs -I {} -P "$pg_servers_count" -n 1 ssh -o StrictHostKeyChecking=no {} "PGPASSWORD='{{ patroni_superuser_password }}' psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc \"$pg_slow_active_terminate_query\""
       fi
 
       # if it was not possible to pause for 60 seconds, exit with an error

automation/roles/upgrade/tasks/post_checks.yml

@@ -29,9 +29,11 @@
 
 - name: Create a table "test_replication" with 10000 rows on the Primary
   ansible.builtin.command: >-
-    {{ pg_new_bindir }}/psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
+    {{ pg_new_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "drop table IF EXISTS test_replication;
     create table test_replication as select generate_series(1, 10000)"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   register: create_table_result
   until: create_table_result is success
   delay: 5
@@ -42,8 +44,10 @@
 
 - name: Wait until the PostgreSQL replica is synchronized
   ansible.builtin.command: >-
-    {{ pg_new_bindir }}/psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
+    {{ pg_new_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "select count(*) from test_replication"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   register: count_test
   until: count_test.stdout | int == 10000
   retries: 60 # max wait time: 2 minutes
@@ -56,8 +60,10 @@
 
 - name: Drop a table "test_replication"
   ansible.builtin.command: >-
-    {{ pg_new_bindir }}/psql -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
+    {{ pg_new_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "drop table IF EXISTS test_replication"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   when:
     - inventory_hostname in groups['primary']
     - create_table_result is success

automation/roles/upgrade/tasks/rollback.yml

@@ -204,6 +204,8 @@
       ansible.builtin.command: >-
         {{ postgresql_bin_dir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
         "select current_setting('server_version')"
+      environment:
+        PGPASSWORD: "{{ patroni_superuser_password }}"
       register: postgres_version
       changed_when: false
 

automation/roles/upgrade/tasks/schema_compatibility.yml

@@ -3,6 +3,8 @@
   ansible.builtin.command: >-
     {{ pg_old_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "show shared_preload_libraries"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   changed_when: false
   register: pg_shared_preload_libraries
   when:
@@ -12,6 +14,8 @@
   ansible.builtin.command: >-
     {{ pg_old_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "select current_setting('cron.database_name', true)"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   changed_when: false
   register: pg_cron_database_name
   when:

automation/roles/upgrade/tasks/statistics.yml

@@ -35,6 +35,8 @@
         done
       args:
         executable: /bin/bash
+      environment:
+        PGPASSWORD: "{{ patroni_superuser_password }}"
       async: "{{ vacuumdb_analyze_timeout }}" # run the command asynchronously with a maximum duration
       poll: 0
       register: pg_terminator_analyze
@@ -62,6 +64,8 @@
         done
       args:
         executable: /bin/bash
+      environment:
+        PGPASSWORD: "{{ patroni_superuser_password }}"
       async: "{{ vacuumdb_analyze_timeout }}" # run the command asynchronously with a maximum duration
       poll: 0
       register: pg_terminator_long_transactions

automation/roles/upgrade/tasks/update_extensions.yml

@@ -85,6 +85,8 @@
     {{ pg_new_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d {{ pg_target_dbname }} -tAXc
     "DROP EXTENSION pg_repack;
     CREATE EXTENSION pg_repack;"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   ignore_errors: true # show the error and continue the playbook execution
   when:
     - inventory_hostname in groups['primary']

automation/roles/upgrade/tasks/upgrade_check.yml

@@ -3,6 +3,8 @@
   ansible.builtin.command: >-
     {{ pg_old_bindir }}/psql -h 127.0.0.1 -p {{ postgresql_port }} -U {{ patroni_superuser_username }} -d postgres -tAXc
     "show shared_preload_libraries"
+  environment:
+    PGPASSWORD: "{{ patroni_superuser_password }}"
   changed_when: false
   register: pg_shared_preload_libraries_result
   when: