Compatibility with Ansible 12 (part 2) (#1321)

Continues integration of Ansible 12 support by fixing compatibility issues discovered during testing.

Author: vitabaks

.github/workflows/molecule_pg_upgrade.yml

@@ -25,30 +25,31 @@ jobs:
           - distro: ubuntu2204
             tag: latest
             namespace: geerlingguy
-          - distro: rockylinux10
-            tag: latest
-            namespace: geerlingguy
-          - distro: rockylinux9
-            tag: latest
-            namespace: geerlingguy
-          - distro: almalinux10
-            tag: latest
-            namespace: glillico
-          - distro: almalinux9
-            tag: latest
-            namespace: glillico
-          - distro: oraclelinux10
-            tag: latest
-            namespace: glillico
-          - distro: oraclelinux9
-            tag: latest
-            namespace: glillico
-          - distro: centosstream10
-            tag: latest
-            namespace: glillico
-          - distro: centosstream9
-            tag: latest
-            namespace: glillico
+# TODO: error "rsync: connection unexpectedly closed" in GitHub CI environment (need to investigate)
+#          - distro: rockylinux10
+#            tag: latest
+#            namespace: geerlingguy
+#          - distro: rockylinux9
+#            tag: latest
+#            namespace: geerlingguy
+#          - distro: almalinux10
+#            tag: latest
+#            namespace: glillico
+#          - distro: almalinux9
+#            tag: latest
+#            namespace: glillico
+#          - distro: oraclelinux10
+#            tag: latest
+#            namespace: glillico
+#          - distro: oraclelinux9
+#            tag: latest
+#            namespace: glillico
+#          - distro: centosstream10
+#            tag: latest
+#            namespace: glillico
+#          - distro: centosstream9
+#            tag: latest
+#            namespace: glillico
 
     steps:
       - name: Set TERM environment variable

automation/roles/cloud_resources/tasks/aws.yml

@@ -582,7 +582,7 @@
             | selectattr('instances','defined') | map(attribute='instances') | list | flatten
             | selectattr('instance_id','defined') | map(attribute='instance_id') | list
           }}
-      loop: "{{ server_result.results | selectattr('instances', 'defined') }}"
+      loop: "{{ server_result.results | selectattr('instances', 'defined') | list }}"
       loop_control:
         label: >-
           public_ip: {{ item.instances[0].public_ip_address | default('') }},
@@ -592,7 +592,7 @@
       ansible.builtin.import_tasks: inventory.yml
   when:
     - server_result.results is defined
-    - server_result.results | selectattr('instances', 'defined')
+    - (server_result.results | selectattr('instances','defined') | list | length) > 0
 
 # Delete the temporary ssh key from the cloud after creating the EC2 instance
 - name: "AWS: Remove temporary SSH key '{{ ssh_key_name | default('') }}' from cloud"

automation/roles/cloud_resources/tasks/azure.yml

@@ -297,9 +297,9 @@
             key_data: "{{ ssh_key_content }}"
         ssh_password_enabled: false
         image:
-          offer: "{{ azure_vm_image_offer | default('0001-com-ubuntu-server-jammy') }}"
+          offer: "{{ azure_vm_image_offer | default('ubuntu-24_04-lts') }}"
           publisher: "{{ azure_vm_image_publisher | default('Canonical') }}"
-          sku: "{{ azure_vm_image_sku | default('22_04-lts-gen2') }}"
+          sku: "{{ azure_vm_image_sku | default('server') }}"
           version: "{{ azure_vm_image_version | default('latest') }}"
         os_type: Linux
         os_disk_size_gb: "{{ system_volume_size | default('80') }}" # system disk size
@@ -386,7 +386,7 @@
             private_ips | default([]) +
             [item.ansible_facts.azure_vm.network_profile.network_interfaces[0].properties.ip_configurations[0].private_ip_address]
           }}
-      loop: "{{ server_result.results | selectattr('ansible_facts.azure_vm', 'defined') }}"
+      loop: "{{ server_result.results | selectattr('ansible_facts.azure_vm', 'defined') | list }}"
       loop_control:
         label: "{{ item.ansible_facts.azure_vm.network_profile.network_interfaces[0].properties.ip_configurations[0].private_ip_address }}"
 
@@ -530,7 +530,7 @@
             | map(attribute='vms') | map('default', []) | list | flatten
             | selectattr('id','defined') | map(attribute='id') | list
           }}
-      loop: "{{ server_result.results | selectattr('ansible_facts.azure_vm', 'defined') }}"
+      loop: "{{ server_result.results | selectattr('ansible_facts.azure_vm', 'defined') | list }}"
       loop_control:
         label: >-
           public_ip: {{ (public_ip_address.results if public_ip_address is defined else []) | selectattr('idx', 'equalto', item.idx) | map(attribute='state.ip_address') | first | default('') }},
@@ -540,7 +540,7 @@
       ansible.builtin.import_tasks: inventory.yml
   when:
     - server_result.results is defined
-    - server_result.results | selectattr('ansible_facts.azure_vm', 'defined')
+    - (server_result.results | selectattr('ansible_facts.azure_vm', 'defined') | list | length) > 0
 
 # Delete (if state is absent)
 - block:

automation/roles/cloud_resources/tasks/digitalocean.yml

@@ -102,13 +102,13 @@
     - name: "DigitalOcean: Get fingerprint for SSH key '{{ ssh_key_name | default('') }}'"
       ansible.builtin.set_fact:
         ssh_key_fingerprint: "{{ [item.fingerprint] }}"
-      loop: "{{ ssh_keys.data | lower }}"
-      loop_control: # do not display the public key
-        label: "{{ item.name }}"
+      loop: "{{ ssh_keys.data | default([]) }}"
+      loop_control:
+        label: "{{ item.name | default('unknown') }}"
       when:
         - ((ssh_key_name | length > 0 and ssh_key_name != (tmp_ssh_key_name | default(''))) or
-          (ssh_key_name == (tmp_ssh_key_name | default('')) and ssh_public_keys | default('') | length > 0))
-        - item.name == ssh_key_name | lower
+          (ssh_key_name == (tmp_ssh_key_name | default('')) and (ssh_public_keys | default('') | length > 0)))
+        - (item.name | lower) == (ssh_key_name | lower)
 
     # Stop, if the ssh key is not found
     - name: "DigitalOcean: Fail if SSH key '{{ ssh_key_name | default('') }}' is not found"
@@ -122,13 +122,13 @@
     # get the fingerprint of all ssh keys
     - name: "DigitalOcean: Get fingerprint for all SSH keys"
       ansible.builtin.set_fact:
-        ssh_key_fingerprint: "{{ ssh_key_fingerprint | default([]) + [item.fingerprint] }}"
-      loop: "{{ ssh_keys.data | lower }}"
-      loop_control: # do not display the public key
-        label: "{{ item.name }}"
+        ssh_key_fingerprint: "{{ (ssh_key_fingerprint | default([])) + [item.fingerprint] }}"
+      loop: "{{ ssh_keys.data | default([]) }}"
+      loop_control:
+        label: "{{ item.name | default('unknown') }}"
       when:
-        - (ssh_key_name | length < 1 or ssh_key_name == (tmp_ssh_key_name | default('')))
-        - (ssh_public_keys is not defined or ssh_public_keys | length < 1)
+        - (ssh_key_name | length < 1) or (ssh_key_name == (tmp_ssh_key_name | default('')))
+        - (ssh_public_keys is not defined) or ((ssh_public_keys | length) < 1)
   when: state == 'present'
 
 # Create (if state is present)
@@ -687,7 +687,7 @@
             | map(attribute='data') | map('default', []) | list | flatten
             | selectattr('id','defined') | map(attribute='id') | list
           }}
-      loop: "{{ droplet_result.results | selectattr('data', 'defined') }}"
+      loop: "{{ droplet_result.results | selectattr('data','defined') | list }}"
       loop_control:
         label: >-
           public_ip: {{ (item.data.droplet.networks.v4 | selectattr('type', 'equalto', 'public')).0.ip_address | default('') }},
@@ -697,7 +697,7 @@
       ansible.builtin.import_tasks: inventory.yml
   when:
     - droplet_result.results is defined
-    - droplet_result.results | selectattr('data', 'defined')
+    - (droplet_result.results | selectattr('data','defined') | list | length) > 0
 
 # Delete the temporary SSH key from the cloud after creating the droplet
 - name: "DigitalOcean: Remove temporary SSH key '{{ ssh_key_name | default('') }}' from cloud"
@@ -757,6 +757,8 @@
         - sync
       loop_control:
         label: "{{ patroni_cluster_name }}-{{ item }}"
+      register: do_lb_del_result
+      failed_when: do_lb_del_result is failed and ('not found' not in (do_lb_del_result.msg | default('') | lower))
       when: cloud_load_balancer | bool and
         (item == 'primary' or
         (item == 'replica' and server_count | int > 1) or

automation/roles/cloud_resources/tasks/gcp.yml

@@ -339,7 +339,7 @@
                 port: "{{ pgbouncer_listen_port | default('6432') }}"
             network:
               selfLink: "global/networks/{{ gcp_network_name }}"
-            instances: "{{ instances_selflink }}"
+            instances: "{{ instances_selflink | from_json }}"
             state: present
           vars:
             region: "{{ server_location[:-2] if server_location[-2:] | regex_search('-[a-z]$') else server_location }}"
@@ -348,9 +348,7 @@
             instances_selflink: >- # TODO: use "{{ server_result.results | map(attribute='selfLink') | map('community.general.dict_kv', 'selfLink') | list }}"
               [
                 {% for i in range(1, (server_count | int) + 1) %}
-                  {
-                    "selfLink": "zones/{{ zone }}/instances/{{ server_name }}{{ '%02d' % i }}"
-                  }{% if not loop.last %},{% endif %}
+                  { "selfLink": "zones/{{ zone }}/instances/{{ server_name }}{{ '%02d' % i }}" }{% if not loop.last %},{% endif %}
                 {% endfor %}
               ]
           register: instance_group
@@ -558,7 +556,7 @@
             | map(attribute='resources') | map('default', []) | list | flatten
             | selectattr('id','defined') | map(attribute='id') | list
           }}
-      loop: "{{ server_result.results | selectattr('networkInterfaces', 'defined') }}"
+      loop: "{{ server_result.results | selectattr('networkInterfaces', 'defined') | list }}"
       loop_control:
         label: >-
           public_ip: {{ item.networkInterfaces[0].accessConfigs[0].natIP | default('') }},
@@ -568,7 +566,7 @@
       ansible.builtin.import_tasks: inventory.yml
   when:
     - server_result.results is defined
-    - server_result.results | selectattr('networkInterfaces', 'defined')
+    - (server_result.results | selectattr('networkInterfaces', 'defined') | list | length) > 0
 
 # Delete (if state is absent)
 - block:

automation/roles/cloud_resources/tasks/hetzner.yml

@@ -723,7 +723,7 @@
             | map(attribute='hcloud_server_info') | map('default', []) | list | flatten
             | selectattr('id','defined') | map(attribute='id') | list
           }}
-      loop: "{{ server_result.results | selectattr('hcloud_server', 'defined') }}"
+      loop: "{{ server_result.results | selectattr('hcloud_server', 'defined') | list }}"
       loop_control:
         label: >-
           public_ip: {{ item.hcloud_server.ipv4_address | default('') }},
@@ -733,7 +733,7 @@
       ansible.builtin.import_tasks: inventory.yml
   when:
     - server_result.results is defined
-    - server_result.results | selectattr('hcloud_server', 'defined')
+    - (server_result.results | selectattr('hcloud_server','defined') | list | length) > 0
 
 # Delete the temporary ssh key from the cloud after creating the server
 - name: "Hetzner Cloud: Remove temporary SSH key {{ ssh_key_name | default('') }} from cloud"

automation/roles/pgbackrest/tasks/ssh_keys.yml

@@ -111,6 +111,9 @@
     target_host: "{{ hostvars[item].get('bind_address') if (item in (groups['postgres_cluster'])) else pgbackrest_repo_host }}"
     target_port: "{{ hostvars[item].get('ansible_ssh_port') or hostvars[item].get('ansible_port') or 22 }}"
   register: ssh_known_host_keyscan
+  until: ssh_known_host_keyscan is succeeded
+  retries: 3
+  delay: 5
   changed_when: false
 
 - name: known_hosts | Add ssh host keys in "~postgres/.ssh/known_hosts" on database servers

automation/roles/pgbackrest/tasks/stanza_create.yml

@@ -36,14 +36,14 @@
     # The delegate_to parameter is used to execute the task on a different host than the one specified in the play's hosts parameter.
     # In this case, the task is delegated to the first host in the pgbackrest group in the invetory.
     - name: Get repo1-path value
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.set_fact:
         repo1_path: "{{ pgbackrest_server_conf['global'] | selectattr('option', 'equalto', 'repo1-path') | map(attribute='value') | list | first }}"
-      when: pgbackrest_repo_type | lower == 'posix'
+      when: (pgbackrest_repo_type | default('posix')) | lower == 'posix'
 
     - name: "Make sure the {{ repo1_path | default('') }} directory exists"
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.file:
         path: "{{ repo1_path }}"
@@ -56,13 +56,16 @@
     - name: Create stanza "{{ pgbackrest_stanza | default('') }}"
       become: true
       become_user: "{{ pgbackrest_repo_user }}"
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.command: "pgbackrest --stanza={{ pgbackrest_stanza }} --no-online stanza-create"
       register: stanza_create_result
       changed_when:
         - stanza_create_result.rc == 0
         - stanza_create_result.stdout is not search("already exists")
+  vars:
+    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([], true) | list | first) | default(inventory_hostname, true) }}"
   when:
-    - pgbackrest_repo_host | length > 0
+    - (pgbackrest_repo_host | default('')) | length > 0
+    - (groups.get('pgbackrest') | default([], true) | length) > 0
   tags: pgbackrest, pgbackrest_stanza_create

automation/roles/ssh_keys/tasks/main.yml

@@ -63,6 +63,9 @@
       ansible.builtin.command: "ssh-keyscan -trsa -p {{ ansible_ssh_port | default(22) }} {{ hostvars[item]['bind_address'] }}"
       loop: "{{ ssh_known_hosts }}"
       register: ssh_known_host_results
+      until: ssh_known_host_results is succeeded
+      retries: 3
+      delay: 5
       changed_when: false
 
     - name: known_hosts | for each host, add/update the public key in the "~{{ ssh_key_user | default('') }}/.ssh/known_hosts"

automation/roles/update/tasks/pgbackrest_host.yml

@@ -4,19 +4,19 @@
 - block:
     - name: Gather facts from pgbackrest server
       ansible.builtin.setup:
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
 
     - name: Update dnf cache
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.shell: dnf clean all && dnf -y makecache
       args:
         executable: /bin/bash
       when: ansible_os_family == "RedHat" and not (skip_dnf_makecache | default(false) | bool)
 
     - name: Update apt cache
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.apt:
         update_cache: true
@@ -28,7 +28,7 @@
       when: ansible_os_family == "Debian"
 
     - name: Install the latest version of pgbackrest package
-      delegate_to: "{{ groups['pgbackrest'][0] }}"
+      delegate_to: "{{ pgbackrest_delegate }}"
       run_once: true
       ansible.builtin.package:
         name: pgbackrest
@@ -39,7 +39,9 @@
       retries: 3
   become: true
   become_user: root
+  vars:
+    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([], true) | list | first) | default(inventory_hostname, true) }}"
   when:
     - pgbackrest_install | bool
-    - pgbackrest_repo_host | default('') | length > 0
-    - groups['pgbackrest'] | default([]) | length > 0
+    - (pgbackrest_repo_host | default('')) | length > 0
+    - (groups.get('pgbackrest') | default([], true) | length) > 0