Improve pgbackrest group handling in Ansible tasks

Updated the usage of groups.get('pgbackrest') and related defaults in stanza_create.yml, pgbackrest_host.yml, and post_upgrade.yml to use the 'default' filter with 'true' and ensure proper type handling. This change improves robustness when the 'pgbackrest' group is missing or empty.

Author: vitabaks

automation/roles/pgbackrest/tasks/stanza_create.yml

@@ -64,8 +64,8 @@
         - stanza_create_result.rc == 0
         - stanza_create_result.stdout is not search("already exists")
   vars:
-    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([]) | first) | default(inventory_hostname) }}"
+    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([], true) | list | first) | default(inventory_hostname, true) }}"
   when:
-    - pgbackrest_repo_host | default('') | length > 0
-    - groups.get('pgbackrest', []) | length > 0
+    - (pgbackrest_repo_host | default('')) | length > 0
+    - (groups.get('pgbackrest') | default([], true) | length) > 0
   tags: pgbackrest, pgbackrest_stanza_create

automation/roles/update/tasks/pgbackrest_host.yml

@@ -40,8 +40,8 @@
   become: true
   become_user: root
   vars:
-    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([]) | first) | default(inventory_hostname) }}"
+    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([], true) | list | first) | default(inventory_hostname, true) }}"
   when:
     - pgbackrest_install | bool
-    - pgbackrest_repo_host | default('') | length > 0
-    - groups.get('pgbackrest', []) | length > 0
+    - (pgbackrest_repo_host | default('')) | length > 0
+    - (groups.get('pgbackrest') | default([], true) | length) > 0

automation/roles/upgrade/tasks/post_upgrade.yml

@@ -152,11 +152,11 @@
   become_user: "{{ pgbackrest_repo_user }}"
   ignore_errors: true # show the error and continue the playbook execution
   vars:
-    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([]) | first) | default(inventory_hostname) }}"
+    pgbackrest_delegate: "{{ (groups.get('pgbackrest') | default([], true) | list | first) | default(inventory_hostname, true) }}"
   when:
     - pgbackrest_install | bool
-    - pgbackrest_repo_host | default('') | length > 0
-    - groups.get('pgbackrest', []) | length > 0
+    - (pgbackrest_repo_host | default('')) | length > 0
+    - (groups.get('pgbackrest') | default([], true) | length) > 0
 
 # WAL-G
 - block: