Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: external_dp blocks normal DP group creation #15176

Closed
1 task done
Selkh opened this issue Mar 20, 2025 · 5 comments · Fixed by #15355 · May be fixed by #15323
Closed
1 task done

[Bug]: external_dp blocks normal DP group creation #15176

Selkh opened this issue Mar 20, 2025 · 5 comments · Fixed by #15355 · May be fixed by #15323
Labels
bug Something isn't working

Comments

@Selkh
Copy link

Selkh commented Mar 20, 2025

Your current environment

0.8.0 & 0.8.1

🐛 Describe the bug

#14899 introduces error for normal DP.

As https://github.com/vllm-project/vllm/blob/main/vllm/distributed/parallel_state.py#L904C35-L904C45 shown, "config.parallel_config.world_size" means tp-size * pp-size defined in config.py while world_size is size of all visible devices from "torch.distributed". As a result, as long as a regular DP size, it will enter this branch as unexpected, thereby preventing the establishment of DP group.

Suppose replace "config.parallel_config.world_size" with "config.parallel_config.world_size_cross_dp" which matches the design of external_dp more.

if config.parallel_config.world_size_cross_dp != world_size:

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@Selkh Selkh added the bug Something isn't working label Mar 20, 2025
@youkaichao
Copy link
Member

looks true, wonder why we don't see it in the test :(

@youkaichao
Copy link
Member

can you create a pr to fix it?

@Selkh
Copy link
Author

Selkh commented Mar 22, 2025

can you create a pr to fix it?

Sure. Thanks for your prompt feedback again.

@youkaichao
Copy link
Member

@Selkh hi, i'm fixing it in #15355 , please check if it works.

@Selkh
Copy link
Author

Selkh commented Mar 23, 2025

@Selkh hi, i'm fixing it in #15355 , please check if it works.

Okay, it looks more compatible and extensible. I will verify locally whether it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants