-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: external_dp blocks normal DP group creation #15176
Closed
1 task done
Labels
bug
Something isn't working
Comments
1 task
looks true, wonder why we don't see it in the test :( |
can you create a pr to fix it? |
Sure. Thanks for your prompt feedback again. |
Selkh
pushed a commit
to Selkh/vllm
that referenced
this issue
Mar 22, 2025
…15176) Signed-off-by: tianyu.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Your current environment
🐛 Describe the bug
#14899 introduces error for normal DP.
As https://github.com/vllm-project/vllm/blob/main/vllm/distributed/parallel_state.py#L904C35-L904C45 shown, "config.parallel_config.world_size" means
tp-size * pp-size
defined in config.py while world_size is size of all visible devices from "torch.distributed". As a result, as long as a regular DP size, it will enter this branch as unexpected, thereby preventing the establishment of DP group.Suppose replace "config.parallel_config.world_size" with "config.parallel_config.world_size_cross_dp" which matches the design of external_dp more.
Before submitting a new issue...
The text was updated successfully, but these errors were encountered: