[Bugfix] Fix prefix_repetition routing in bench throughput #29663
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a bug in
vllm bench throughputwhere--dataset-name prefix_repetitionis incorrectly routed toRandomDatasetwhen--dataset-pathis not provided, due to:This causes prefix-repetition benchmarks to ignore
--prefix-repetition-*arguments and fall back to random dataset defaults (e.g. input-len=1024, output-len=128).The fix makes prefix_repetition explicitly use
PrefixRepetitionRandomDatasetwith its own CLI args, and only usesRandomDatasetfor true random/default cases.Test Plan
Test Result
1. prefix_repetition test
(≈ 60 + 40 input tokens and 1 output token, as configured.)
2. random regression test
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.