Skip to content

Conversation

@halyavin
Copy link
Contributor

@halyavin halyavin commented Nov 28, 2025

Purpose

Fix building VLLM wheel using VLLM docker image. Mostly fixes issue #29669.

In pull request #29270 we switched from devel to basic nvidia image as a base for the default and test VLLM docker image. This basic nvidia image doesn't contain all libraries needed to build a VLLM wheel. Even though we install nvrtc library in test VLLM docker image, CMake can't find it. But when I install dev version of nvrtc library, CMake does find it and fails while compiling kernels. I found the minimum set of dev libraries needed to compile VLLM wheel successfully. Original test image size is 24.8Gb. With dev libraries it is 28.6Gb. With devel nvidia image it is 34.4Gb. In any case, changes in test image do not increase the size of default docker image.

This change doesn't fix that build python package is missing in the test VLLM docker image.

Test Plan

Build VLLM test docker image.
docker build ./vllm --target test --tag ... --file ./vllm/docker/Dockerfile
Run VLLM test docker image.
docker container run --rm -it --network host --gpus all --shm-size=2g --entrypoint /bin/bash -v [map vllm dir] ...
Build full VLLM wheel.
pip install build && cd vllm && python3 -m build --wheel

Test Result

VLLM wheel is build.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Nov 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix building the VLLM wheel inside the test docker image by adding necessary development libraries. However, the current implementation adds these libraries to a base image (vllm-base) that is shared with the production docker image, which unnecessarily increases its size by about 4GB. My review provides a critical comment suggesting to move the installation of these development libraries to the test stage only, to keep the production image lean while still fixing the build issue in the test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant