-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[CI] Renovation of nightly wheel build & generation #29690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Harry-Chen
wants to merge
11
commits into
vllm-project:main
Choose a base branch
from
Harry-Chen:nightly-wheel-reno
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+493
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8580d1 to
7116066
Compare
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
…download precompiled wheels Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
7116066 to
1ca284e
Compare
Signed-off-by: Shengqi Chen <[email protected]>
1ca284e to
82e406e
Compare
…ult variant is found Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
…load Signed-off-by: Shengqi Chen <[email protected]>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
vllm's nightly build needs to be renovated due to the following reasons:
/<commit>/,/nightly/,/<version>/directory1.0.0.devwheel for the sole purpose of finding a precompiled wheelIn this PR, I have renovated the whole process. This includes:
generate-nightly-index.py) to elegantly handle the generation of indices and an extrametadata.json. It supports auto-creation of sub-indices for different variants (with automatic detection). Please read the comments in the code for a detailed explanation.upload-wheels.shto upload one binary wheel only once after each successful build of any wheel. It will callgenerate-nightly-index.pyto generate the index for all currently present wheels in the directory, and copy the indices to all necessary locations (e.g./<commit>/,/nightly/if it is on the master branch, and/<version>/if it is not a dev version).1.0.0.devwheels are uploaded to S3.manylinux1andmanylinux2014are corrected withmanylinux_2_31, which reflects the glibc version of vllm's building image (ubuntu-20.04)setup.pyis changed accordingly to download themetadata.jsonto find the actual wheel path, not using the hardcoded1.0.0.devanymore.More nits:
VLLM_MAIN_CUDA_VERSIONis bumped to 12.9 to avoid confusion.Test Plan
It's all CI changes. Let's test it by CI.
Test Result
release-pipelinehas passed.test-pipelinewill probably fail onpython_only_compile.sh, which testsVLLM_USE_PRECOMPILEDwith build namenightly. However, before this PR is merged tomain, no new indices and metadata will be uploaded to/nightly/.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.