Skip to content

Conversation

@KuntaiDu
Copy link
Collaborator

@KuntaiDu KuntaiDu commented Nov 28, 2025

Purpose

As v0 engine is now fully removed, it is time to remove v0-related kv connector components such as kv pipe and kv lookup buffer.

Test

  1. Made sure that kv_lookup_buffer and kv_pipe no longer exists in vLLM codebase
  2. Made sure that v1 connector is unaffected, by testing
vllm serve deepseek-ai/DeepSeek-V2-Lite --kv-offloading-backend lmcache --kv-offloading-size 100

and LMCache multi-processing connector.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a significant amount of code related to the now-obsolete v0 KV connector, including KV pipes and lookup buffers. The changes consist entirely of deleting unused files and their corresponding tests. This is an excellent cleanup effort that simplifies the codebase by removing legacy components. The tests described in the pull request description appear sufficient to verify that the v1 connector is unaffected by these changes. The deletions are appropriate and the pull request looks good to merge.

@mergify mergify bot added the kv-connector label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant