-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[LoRA] Support FusedMoE LoRA Triton kernel for mxfp4 #29708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xin Yang <[email protected]>
Signed-off-by: Xin Yang <[email protected]>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-introduces support for FusedMoE LoRA with Triton kernels for mxfp4 quantization, which was previously reverted. The changes are well-structured and mainly involve:
- Adding an
UnfusedOAITritonExpertsclass to allow for LoRA injection by separating GEMM, activation, and reduction steps. - Updating the mxfp4 backend selection logic to enable the Triton backend for LoRA when available.
- Adding a comprehensive test suite to validate the new unfused Triton kernel against a PyTorch reference implementation.
The changes look solid and align with the goal of modularizing the MoE kernels. I have a couple of suggestions for improving maintainability and robustness.
3e5e554 to
b55736c
Compare
Co-authored-by: Jee Jee Li <[email protected]> Signed-off-by: Xin Yang <[email protected]>
Purpose
#28971 got reverted by #29697 because of breaking tests. This PR redo #28971.
Test Plan
Test Result
Unit test passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.@jeejeelee @DarkLight1337 Please take a look. Thanks a lot for reviewing!